refactor: remove UI initialisation callbacks #26969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
matthewwalsh0
commented
Sep 6, 2024
| if (isManifestV3 && isUIInitialised) { | ||
| // Currently when service worker is revived we create new streams | ||
| // in later version we might try to improve it by reviving same streams. | ||
| updateUiStreams(); |
There was a problem hiding this comment.
My understanding is that we can now be certain the service worker will never restart while the browser is open, meaning this logic and the resetExtensionStreamAndListeners branch below is superfluous.
But for the sake of keeping this PR as a pure refactor with no functional changes, I've left it for now.
Builds ready [2918681]
Page Load Metrics (1937 ± 246 ms)
Bundle size diffs
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #26969 +/- ##
===========================================
+ Coverage 70.17% 70.19% +0.02%
===========================================
Files 1425 1425
Lines 49647 49639 -8
Branches 13889 13886 -3
===========================================
+ Hits 34836 34842 +6
+ Misses 14811 14797 -14 ☔ View full report in Codecov by Sentry. |
pedronfigueiredo
approved these changes
Sep 10, 2024
vinistevam
approved these changes
Sep 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace legacy callback chain in UI initialisation with promises and async functions to improve readability and simplify maintenance.
Also removes some duplication in MV3 and legacy code.
Related issues
Manual testing steps
No functional changes.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist