Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Ensure get-changed-files-with-git-diff scripts does not run on the master branch #26992

Merged
merged 1 commit into from
Sep 9, 2024
Merged

ci: Ensure get-changed-files-with-git-diff scripts does not run on the master branch #26992

merged 1 commit into from
Sep 9, 2024

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Sep 9, 2024 •
edited by github-actions bot
Loading

Description

For some reason, process.env.CIRCLE_PULL_REQUEST is defined when running the git-diff-develop.ts script on the master branch. This causes that script to fail, which in turn prevents the build from passing. This PR ensures that script does not run on the master branch.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@danjm danjm requested review from kumavis and a team as code owners September 9, 2024 18:24
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@danjm danjm changed the title Ensure get-changed-files-with-git-diff scripts does not run on the ma… ci: Ensure get-changed-files-with-git-diff scripts does not run on the master branch Sep 9, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.13%. Comparing base (d6d43eb) to head (65a9de4).
Report is 4 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #26992      +/-   ##
===========================================
- Coverage    70.13%   70.13%   -0.00%     
===========================================
  Files         1425     1425              
  Lines        49669    49668       -1     
  Branches     13895    13895              
===========================================
- Hits         34833    34832       -1     
  Misses       14836    14836

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [65a9de4]
Page Load Metrics (1724 ± 69 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44020571652308148
domContentLoaded15802010170012861
load15902069172414569
domInteractive149134178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

desi
desi approved these changes Sep 9, 2024
View reviewed changes
Copy link

@desi desi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danjm danjm merged commit 4a4b938 into develop Sep 9, 2024
84 of 85 checks passed
@danjm danjm deleted the no-git-diff-script-master branch September 9, 2024 20:28
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
@metamaskbot metamaskbot added release-12.6.0 Issue or pull request that will be included in release 12.6.0 release-12.2.2 Issue or pull request that will be included in release 12.2.2 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 9, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-12.2.2 on PR. Adding release label release-12.2.2 on PR and removing other release labels(release-12.6.0), as PR was cherry-picked in branch 12.2.2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@desi desi desi approved these changes

@davidmurdoch davidmurdoch davidmurdoch approved these changes

@vthomas13 vthomas13 vthomas13 approved these changes

@DDDDDanica DDDDDanica DDDDDanica approved these changes

@kumavis kumavis Awaiting requested review from kumavis kumavis is a code owner

Assignees
No one assigned
Labels
release-12.2.2 Issue or pull request that will be included in release 12.2.2 team-extension-platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@danjm @metamaskbot @desi @davidmurdoch @vthomas13 @DDDDDanica