chore: bump @metamask/base-controller to ^7.0.0 #27032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
@metamaskbot update-policies |
|
Policies updated |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #27032 +/- ##
========================================
Coverage 70.15% 70.15%
========================================
Files 1425 1425
Lines 49653 49653
Branches 13891 13891
========================================
Hits 34833 34833
Misses 14820 14820 ☔ View full report in Codecov by Sentry. |
Builds ready [f725f75]
Page Load Metrics (1631 ± 65 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [7168c56]
Page Load Metrics (1900 ± 74 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [f4e0387]
Page Load Metrics (1677 ± 76 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Builds ready [b53d4f5]
Page Load Metrics (1804 ± 107 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There is a more broad epic to update other controllers to their latest versions: https://github.com/MetaMask/MetaMask-planning/issues/3234 |
mikesposito
approved these changes
Sep 11, 2024
ccharly
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Same comment than @legobeat. It does not entirely address the ticket, since multiple controllers are still using another version of @metamask/base-controller, examples of some accounts related controllers:
├─ @metamask/accounts-controller@npm:17.2.0
│ └─ @metamask/base-controller@npm:6.0.3 (via npm:^6.0.0)
│
├─ @metamask/accounts-controller@npm:18.1.0
│ └─ @metamask/base-controller@npm:6.0.3 (via npm:^6.0.3)
│
├─ @metamask/accounts-controller@npm:18.1.0 [15918]
│ └─ @metamask/base-controller@npm:6.0.3 (via npm:^6.0.3)
│
├─ @metamask/accounts-controller@npm:17.2.0 [d6046]
│ └─ @metamask/base-controller@npm:6.0.3 (via npm:^6.0.0)
...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps @metamask/base-controller to v7.0.0.
Related issues
Fixes: #26920
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist