Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python - Get Started phase 1 links update #1382

Conversation

kingralph33
Copy link

Description

The links within Phase 1 of the Python Get Started article currently get a 404 - page not found. This PR updates the links to the correct file path.

Type of change

The current links have /azure/developer/ in the path. This PR corrects the path by removing /azure/developer/ and replacing it with /articles/

Testing

Verified that each link works via manually clicking each link

Copy link
Contributor

Learn Build status updates of commit ed39a10:

✅ Validation status: passed

File Status Preview URL Details
articles/python/get-started.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Court72
Copy link
Contributor

Court72 commented Apr 10, 2024

@kingralph33,

Thank you for your contribution. Would you take a moment to sign the Contributor License Agreement (CLA)? After the CLA is signed, someone can review your pull request.

Thanks!

@Court72
Copy link
Contributor

Court72 commented Apr 10, 2024

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Apr 10, 2024
@kingralph33
Copy link
Author

@kingralph33 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Copy link
Contributor

@kingralph33 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@Court72
Copy link
Contributor

Court72 commented Apr 10, 2024

@bobtabor-msft

Can you review the proposed changes?

When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

@bobtabor-msft
Copy link
Contributor

@kingralph33 Thank you for your submission. I just tested this on several browsers and the URLs work fine. Can you send me the full URL you are trying to access (after our servers redirect you based on your language-country)?

@bobtabor-msft
Copy link
Contributor

@kingralph33 Thank you, I see where the disconnect is. These pages are not intended to be consumed on GitHub. Rather, they get transformed and built into learn.microsoft.com articles. So, for example, this is the ACTUAL RENDERED page you have requested to change:

https://learn.microsoft.com/en-us/azure/developer/python/get-started

If you click through the links, they all work because the file location on the hard drive (or in GitHub) do not determine the URL.

So, I appreciate your submission, but this works as intended currently. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants