Split requirements for inlining to make more understandable #9889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current list of requirements is a mixture of requirements for the function definition and requirements for the context it is being used in. There are also duplicate requirements in the examples section. This change splits the list into requirements for the function AND another list for the requirements of the context. It also removes the duplicate "examples" and refers users to the concise list.
|
@simonsabin : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 769ed9f: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Can you review the proposed changes? Important: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
|
@simonsabin Thanks, we're doing a separate internal PR to incorporate your changes, and you'll still get credit. When that PR merges, this one will automatically close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current list of requirements is a mixture of requirements for the function definition and requirements for the context it is being used in. There are also duplicate requirements in the examples section.
This change splits the list into requirements for the function AND another list for the requirements of the context. It also removes the duplicate "examples" and refers users to the concise list.