-
Notifications
You must be signed in to change notification settings - Fork 216
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Code Change] AzCopy Error Improvements (#2647)
* initial changes for error codes * support multiple error codes * additional places for error code url * e2e test for error codes * updating tests * update sync test
- Loading branch information
1 parent
a96df7b
commit 43eb15e
Showing
10 changed files
with
178 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
package cmd | ||
|
||
import ( | ||
"github.com/Azure/azure-sdk-for-go/sdk/storage/azblob/bloberror" | ||
"strings" | ||
) | ||
|
||
// errorURLs - map of error codes that currently have shorthand URLs | ||
var errorURLs = map[bloberror.Code]string{ | ||
bloberror.InvalidOperation: "https://aka.ms/AzCopyError/InvalidOperation", | ||
bloberror.MissingRequiredQueryParameter: "https://aka.ms/AzCopyError/MissingRequiredQueryParameter", | ||
bloberror.InvalidHeaderValue: "https://aka.ms/AzCopyError/InvalidHeaderValue", | ||
bloberror.InvalidAuthenticationInfo: "https://aka.ms/AzCopyError/InvalidAuthenticationInfo", | ||
bloberror.NoAuthenticationInformation: "https://aka.ms/AzCopyError/NoAuthenticationInformation", | ||
bloberror.AuthenticationFailed: "https://aka.ms/AzCopyError/AuthenticationFailed", | ||
bloberror.AccountIsDisabled: "https://aka.ms/AzCopyError/AccountIsDisabled", | ||
bloberror.ResourceNotFound: "https://aka.ms/AzCopyError/ResourceNotFound", | ||
bloberror.ResourceTypeMismatch: "https://aka.ms/AzCopyError/ResourceTypeMismatch", | ||
bloberror.CannotVerifyCopySource: "https://aka.ms/AzCopyError/CannotVerifyCopySource", | ||
bloberror.ServerBusy: "https://aka.ms/AzCopyError/ServerBusy", | ||
} | ||
|
||
// getErrorCodeUrl - returns url string for specific error codes | ||
func getErrorCodeUrl(err error) string { | ||
var urls []string | ||
for code, url := range errorURLs { | ||
if hasCode(err, code) { | ||
urls = append(urls, url) | ||
} | ||
} | ||
|
||
if len(urls) > 0 { | ||
return "ERROR DETAILS: " + strings.Join(urls, "; ") | ||
} | ||
|
||
return "" // We do not currently have a URL for this specific error code | ||
} | ||
|
||
// hasCode - checks if err contains blob error code | ||
func hasCode(err error, code bloberror.Code) bool { | ||
return strings.Contains(err.Error(), string(code)) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters