-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate azure-communication-callingserver to azure-json #41101
base: main
Are you sure you want to change the base?
migrate azure-communication-callingserver to azure-json #41101
Conversation
API change check APIView has identified API level changes in this PR and created following API reviews. |
require: | ||
- https://github.com/richardcho-msft/azure-rest-api-specs/blob/dev-communication-CallingServer-2022-04-07-preview/specification/communication/data-plane/CallingServer/readme.md | ||
- https://github.com/Azure/azure-rest-api-specs/blob/anuchan/add-callingserver-2022-04-07-preview/specification/communication/data-plane/CallingServer/readme.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The swagger link was pointing to someone's personal repo that no longer exists. But I found a copy in the .NET repo. We’ll be asking service team to have it in official rest-api-repo main branch. For the purpose of this PR, I pushed it to a non-main branch in official rest-api-repo
// objectMapper.disable(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES); | ||
// CommunicationErrorResponse communicationErrorResponse = objectMapper.convertValue( | ||
// internalHeaders.getValue(), CommunicationErrorResponse.class); | ||
// error = convert(communicationErrorResponse.getError()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something to follow up with Alan. i.e., how to deser the Object internalHeaders.getValue()
Can close/drop this work as the callingserver is being deprecated |
No description provided.