migrate azure-communication-callingserver to azure-json #41101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
anuchandy
commented
Jul 10, 2024
| require: | ||
| - https://github.com/richardcho-msft/azure-rest-api-specs/blob/dev-communication-CallingServer-2022-04-07-preview/specification/communication/data-plane/CallingServer/readme.md | ||
| - https://github.com/Azure/azure-rest-api-specs/blob/anuchan/add-callingserver-2022-04-07-preview/specification/communication/data-plane/CallingServer/readme.md |
There was a problem hiding this comment.
The swagger link was pointing to someone's personal repo that no longer exists. But I found a copy in the .NET repo. We’ll be asking service team to have it in official rest-api-repo main branch. For the purpose of this PR, I pushed it to a non-main branch in official rest-api-repo
| // objectMapper.disable(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES); | ||
| // CommunicationErrorResponse communicationErrorResponse = objectMapper.convertValue( | ||
| // internalHeaders.getValue(), CommunicationErrorResponse.class); | ||
| // error = convert(communicationErrorResponse.getError()); |
There was a problem hiding this comment.
This is something to follow up with Alan. i.e., how to deser the Object internalHeaders.getValue()
|
Can close/drop this work as the callingserver is being deprecated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.