Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E tests #2061

Merged
merged 23 commits into from
Feb 17, 2023
Merged

E2E tests #2061

merged 23 commits into from
Feb 17, 2023

Conversation

JMach1
Copy link
Member

@JMach1 JMach1 commented Jan 11, 2023 •
edited by f-alizada
Loading

Add infra for running e2e tests.

  • Mock server per each test => flexibility for different cases
  • pipeline
  • examples of e2e tests

@github-actions
Copy link

Accessibility Insights Accessibility Insights Action: All applicable checks passed

  • URLs: 13 URL(s) passed, and 0 were not scannable
  • Rules: 28 check(s) passed, and 24 were not applicable
  • Download the Accessibility Insights artifact to view the detailed results of these checks

This scan used axe-core 4.3.2 with Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36.

harunrst
harunrst reviewed Jan 18, 2023
View reviewed changes
package.json Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 15, 2023
View reviewed changes
tests/mocks/collection/user.ts
},
{
"name": "ocp-apim-sas-token",
"value": await Utils.getSharedAccessToken(this.publicId, "accesskey", 1)

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "accesskey" is used as [key](1).
@f-alizada f-alizada marked this pull request as ready for review February 16, 2023 11:18
DeagleGross
DeagleGross approved these changes Feb 16, 2023
View reviewed changes
Copy link

@DeagleGross DeagleGross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but suggesting to wait for devPortal expert to review

Mielek
Mielek reviewed Feb 16, 2023
View reviewed changes
.github/workflows/test.yml Show resolved Hide resolved
tests/e2e/runtime/apis.spec.ts Show resolved Hide resolved
@f-alizada f-alizada merged commit a468b81 into master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-alizada f-alizada f-alizada left review comments

@Mielek Mielek Mielek approved these changes

@DeagleGross DeagleGross DeagleGross approved these changes

@malincrist malincrist malincrist approved these changes

@harunrst harunrst Awaiting requested review from harunrst

@azaslonov azaslonov Awaiting requested review from azaslonov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JMach1 @Mielek @harunrst @DeagleGross @malincrist @f-alizada