Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix main #29

Merged
merged 3 commits into from
Apr 20, 2023
Merged

Fix main #29

merged 3 commits into from
Apr 20, 2023

Conversation

michael-hawker
Copy link
Member

Fixes an issue with primitives test from #18

The branch protections had status checks required, but didn't list them. So, whenever we enabled merge queue it was basically just randomly merging sometimes as some number of checks passed before they had all queued up or something. I've added our steps into the list, so this shouldn't happen again.

This looks like the only failing test, and outside of the .NET Native issue, we should be good with this.

@michael-hawker
Copy link
Member Author

Not too sure what's wrong with test here:

Failed Test_UniformGrid_AutoLayout_FixedElementZeroZeroSpecial [275 ms]
  Error Message:
   Test method PrimitivesExperiment.Tests.Test_UniformGrid_AutoLayout.Test_UniformGrid_AutoLayout_FixedElementZeroZeroSpecial threw exception: 
Microsoft.UI.Xaml.Markup.XamlParseException: XAML parsing failed.
  Stack Trace:
      at WinRT.ExceptionHelpers.<ThrowExceptionForHR>g__Throw|20_0(Int32 hr)
   at ABI.Microsoft.UI.Xaml.Markup.IXamlReaderStaticsMethods.Load(IObjectReference _obj, String xaml)
   at PrimitivesExperiment.Tests.Test_UniformGrid_AutoLayout.Test_UniformGrid_AutoLayout_FixedElementZeroZeroSpecial() in D:\a\Windows\Windows\components\Primitives\tests\Test_UniformGrid_AutoLayout.cs:line 77

Flipping it to use a backing test page with the new setup and trying locally.

…age vs. XamlReader

Had strange issues running locally though, but passed in WinUI 3 which it wasn't in CI...
@michael-hawker
Copy link
Member Author

We'll see if this works, had some weird issues running tests locally, but this one passed for WinUI 3, which it wasn't in CI. Though was getting other errors from XamlReader for UWP... I think there may be some threading issues when trying to run the old test methods in VS. I know for the extensions I had to spend some time updating the DispatcherQueue extensions to the new test syntax to better make use of the async support we have.

@michael-hawker
Copy link
Member Author

Just fighting .NET Native now it looks like!

@michael-hawker
Copy link
Member Author

Going to see if this runs better when being integrated (also so we don't have to wait for this to succeed twice). Had run tests and build UWP locally, so should be good here.

Wondering if we hit shared VM resource constraints at certain times/days of week and maybe that's why its an intermittent issue?

@michael-hawker michael-hawker merged commit df4b483 into main Apr 20, 2023
@delete-merged-branch delete-merged-branch bot deleted the llama/fix-main branch April 20, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant