Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable Testspaces Test Reporting #40

Merged
merged 2 commits into from
May 3, 2023
Merged

Conversation

michael-hawker
Copy link
Member

@michael-hawker michael-hawker commented Apr 22, 2023

Fixes #3

Pretty sure we just commented this out, now that the repo is public this should just work again. I added the repo back in the TestSpace portal.

Note: We'll need to add the checks in the branch protections once these are running:

image

image

The testspaces one (should appear searchable pretty easily once it has run once in the job successfully):

image

@michael-hawker michael-hawker added the enhancement New feature or request label Apr 22, 2023
@michael-hawker
Copy link
Member Author

michael-hawker commented Apr 22, 2023

Looks like Testspace is working fine from the WinUI 3 build:

image

Checked the report and all the WinUI 3 tests appeared to pass. Just .NET Native memory fail again for WinUI 2... 😢 Saw some more details I don't think we had highlighted yet, so passed those along.

@michael-hawker
Copy link
Member Author

Yay, it ran to completion, looks like all the baseline tests we have are still passing too!

image

Enabled it in the branch protection rules, so just need someone to merge the PR! 🙂

Then we can get to improving the tests for everything here and new things brought over.

@Arlodotexe Arlodotexe added this pull request to the merge queue Apr 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 27, 2023
@Arlodotexe Arlodotexe added this pull request to the merge queue Apr 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 28, 2023
@Arlodotexe Arlodotexe added this pull request to the merge queue Apr 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 29, 2023
@Arlodotexe
Copy link
Member

Arlodotexe commented May 1, 2023

Something odd going on with the merge queue, it tries to run the status checks again but they never run, causing the merge queue to time out 🤔

@Arlodotexe Arlodotexe added this pull request to the merge queue May 1, 2023
@Arlodotexe Arlodotexe removed this pull request from the merge queue due to a manual request May 1, 2023
@Arlodotexe Arlodotexe added this pull request to the merge queue May 1, 2023
@Arlodotexe Arlodotexe removed this pull request from the merge queue due to a manual request May 1, 2023
@nmetulev nmetulev enabled auto-merge May 1, 2023 18:27
@Arlodotexe Arlodotexe disabled auto-merge May 1, 2023 18:27
@Arlodotexe Arlodotexe added this pull request to the merge queue May 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 1, 2023
@Arlodotexe Arlodotexe added this pull request to the merge queue May 1, 2023
@Arlodotexe
Copy link
Member

Arlodotexe commented May 2, 2023

Merge queue is working correctly now, but we're hitting more ILT0005. Rerunning a build inside the merge queue doesn't reset the check timeout, causing this PR to timeout and get removed every time it fails. Going to keep trying, and continue on CommunityToolkit/Tooling-Windows-Submodule#9 in the meantime.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 2, 2023
@Arlodotexe Arlodotexe added this pull request to the merge queue May 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 2, 2023
@Arlodotexe Arlodotexe added this pull request to the merge queue May 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 2, 2023
@Arlodotexe Arlodotexe added this pull request to the merge queue May 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 2, 2023
@Arlodotexe Arlodotexe added this pull request to the merge queue May 3, 2023
@michael-hawker
Copy link
Member Author

Merge queue is a bit weird with how it behaves, I don't fully understand how it's supposed to work. I'd just turn it off and merge this rather than getting caught up on automation process. We don't have a ton of PRs coming in to make use of the merge queue at the moment anyway.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 3, 2023
@Arlodotexe Arlodotexe merged commit d9b939b into main May 3, 2023
7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the llama/reenable-tests branch May 3, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up test reporting
2 participants