Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved styling customization SizerBase #96

Merged
merged 3 commits into from
Jun 14, 2023

Conversation

niels9001
Copy link
Collaborator

@niels9001 niels9001 commented Jun 14, 2023

@michael-hawker pointed out that with the visual refresh we lost the ability to set the Padding and CornerRadius.

This PR introduces the following changes:

  • Renaming SizerBaseMargin to SizerBasePadding
  • The Padding and CornerRadius can now be set for better customization:

image

Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niels9001 quick question on margin.

@Arlodotexe also not sure why uno warnings are showing up in the GitHub changed view on different files?

image

components/Sizers/src/SizerBase.xaml Outdated Show resolved Hide resolved
@michael-hawker michael-hawker merged commit 57697fb into main Jun 14, 2023
7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the niels9001/sizer-improvements branch June 14, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants