Feature/variable dt #1148
Merged
Feature/variable dt #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variable time step
|
restart is plausible but turns out to be wrong here. Work on time step info in chkp file is on-going. |
modify the dt setting for the first time step: make the cfl to be exactly the set cfl modify the restart subroutine: take tlag and dtlag from check point file
njansson
requested changes
Feb 26, 2024
Co-authored-by: Niclas Jansson <njansson@kth.se>
Co-authored-by: Niclas Jansson <njansson@kth.se>
Co-authored-by: Niclas Jansson <njansson@kth.se>
Co-authored-by: Niclas Jansson <njansson@kth.se>
Co-authored-by: Niclas Jansson <njansson@kth.se>
njansson
approved these changes
Feb 26, 2024
|
Please update case-file.md with the new options. |
timofeymukha
requested changes
Feb 26, 2024
Co-authored-by: Timofey Mukha <timofeymukha@users.noreply.github.com>
Co-authored-by: Timofey Mukha <timofeymukha@users.noreply.github.com>
Co-authored-by: Timofey Mukha <timofeymukha@users.noreply.github.com>
…le frequently in time stepping
Feature/variable dt
|
It seems you are missing an update to the .depends, which is why the tests are failing. |
Yes it's the issue. now it's fixed. |
Done |
…ep for the restart is set to satisfy the set cfl
timofeymukha
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is re-issued following PR #1013. The branch in PR #1013 is too old and hence full of conflicts. This branch is built on most up-to-date develop-branch. In this branch, two things are modified:
Special acknowledge to @adperezm for setting up the architecture in PR#1013.