Canadians!

Looks good so far.

That's not it yet :/ Rendering of a menu for a given pageUid which is a mountpoint still not working. I'm on it.

Good enough for a pic. ;)
Mind prefixing it with WIP?

I just updated this patch and we're getting closer I think. Tests are highly appreciated. Ping @MichiSpandl.

@bjo3rnf Hey, Great that you worked on it! Many thanks for this. Just to be sure, in which versions (typo3, vhs) are you working and testing?

@MichiSpandl it's vhs dev branch and TYPO3 6.2.2.

Cheers
Björn

Did anyone having an actual use case test this patch? Actually, I'm not quite sure what the expected behavior is for Show Content from Mounted Page Some feedback would be appreciated.

@MichiSpandl could you give some feedback please? You were kind of keen to get this fixed so...
Thanks in advance.
Cheers
Björn

Rebase needed - and of course also feedback on whether this solves the reported problem, before we merge.

Looks like it's still unmergeable.

I tried to test the new behavior of mountpoints on TYPO3 6.2.3 and installed the dev branches of all fluid-extensions (see screen attached). But in the frontend I get "Could not analyse class:Tx_Vhs_ViewHelpers_Page_Content_RenderViewHelper maybe not loaded or no autoloader?" and in the backend I cannot select page templates (see screen). This is why we cannot test the mountpoints at the moment ... :/

Hi @realJustmike - v:page.content.* are deprecated since VHS 1.6.0 I think it was - use instead v:content.get and v:content.render.

@NamelessCoder - thank you. I did a test: the behavior is the same as before. Please have a look at http://p225022.mittwaldserver.info/typo3/
The fluid-menu differs from the Typoscript-menu: the last page in the menu is page-type "mountpoint". The typoscript-menu generates the following link:
http://p225022.mittwaldserver.info/page-1-used-as-mounted-page/
The fluid-menu generates:
http://p225022.mittwaldserver.info/pages/page-1-used-as-mounted-page/
which is in fact a shortcut, but not a mountpoint ...

Hi @realJustmike,

thanks for testing, much appreciated. Could you please disable realurl in your examples to have a better view on the resulting URL parameters? Thanks again.

Cheers
Björn

@bjo3rnf disabled realurl now - as you can see, Typoscript adds the GET param "MP" to the URL:
http://p225022.mittwaldserver.info/index.php?id=5&MP=5-8
fluid does not:
http://p225022.mittwaldserver.info/index.php?id=5
Cheers
Mike

Yes, that's what I was aiming at. Thanks a lot.

@realJustmike how is the mountpoint in your example configured (show content from this page or from mounted page)?

@realJustmike mind giving it another try? I think I fixed it but a test from your side is highly appreciated. Thanks in advance.

Migrated to namespaces and force pushed. Please, folks, test this one. Thanks.

@bjo3rnf the mountpoint is configured as "show content from mounted page". How to get your latest changes? Is there a git command? I cloned the vhs repository again and checked out the development branch but the behavior of our example is the same as before ...

git checkout -b bjo3rnf-mounty development
git pull https://github.com/bjo3rnf/vhs.git mounty

That will pull in @bjo3rnf s changes to your local git

@cedricziel thank you for this fast reply. the git commands worked, 45 files were changed. @bjo3rnf however, the menu in our example did not change. please let me know if you need further details from me.

Thanks for your feedback @realJustmike! 45 files? I changed one single file and the changes I made have to affect the resulting menu. Hm. Is your above link still valid and could you by any chance provide backend access for me?

@realJustmike I can confirm the described behavior for "show content from mounted page" :/ so I'll investigate further. The behavior for "show content from this page" should be correct though. Thanks again.

The amount of files is realistic as you pull in the complete branch with all changes happening in the tree in the meantime 'til HEAD.

@realJustmike would you mind testing again? I added another small fix which now works for me as expected. Please make sure to rewind the repo and pull again. Thanks again and sorry for the spam ;)

@bjo3rnf hey, looks good now! great job! we will test it in a real-world environment and post the result asap here. thank you very much.

Woot! Thanks a lot. Looking forward to the real-world test.

@bjo3rnf in the real-world test we discovered the following issue: the first menu-item is rendered as expected (with GET params) but the sub-menu-items are not. please have a look at the screen and at the following url:
http://p229743.mittwaldserver.info/index.php?id=21&L=0

The layer-menu at the top of the page is the fluid-menu. "Standorte-Länder" is a mountpoint and is rendered with GET params. However, the sub-items ("Österreich", "Deutschland", ...) have no GET params.

Below the fluid-menu we inserted a typoscript-menu. Please compare these two menus.

thank you.

Hi @realJustmike,

thanks again for your feedback. I added another modification which makes the menu work as expected here on my machine (at least I think so). Please give it another try.

Cheers
Björn

Hi @bjo3rnf,
thank you but there is no difference in our installation:
http://p229743.mittwaldserver.info/index.php?id=21&L=0

Please let me know if you need further informations!

Hi @realJustmike,

please see my demo installation on http://t3dev.hamal.uberspace.de where the menus are working as expected. I could provide access to that installation for you to reproduce your menu setup there or have a closer look if you like.

Cheers
Björn

I forgot to mention: the very last entry is a mountpoint to page id 7.

Hey @bjo3rnf, it would be great if you can give us access to your demo site. I will have a look whats the difference in our settings.
Many thanks in advance,
Michi

Hi @MichiSpandl,

did you spot something already?

Cheers
Björn

Seems to work if I use the templates from your ft3dev Ext @bjo3rnf
Now I'm searching for the mistake in our menu configuration!

Hi @MichiSpandl,

are you by any chance rendering the menu manually? The current solution only works with auto rendering I think.

Cheers
Björn

@bjo3rnf I checked it this morning and yes we are rendering it manually. Our menu is a little bit complicated and so we need to render it manually. Which parameter I have to give the pageUid Parameter so that it could work?
Many Thanks, Michi

@MichiSpandl use item.link to get the full url instead of item.uid to create it with another vh.

@bjo3rnf item.link for the pageUid param or for the href itself?

@MichiSpandl I think both should actually work ;)

@NamelessCoder both is not working for me ;) have to check now if it's my failure or if it is really not working...

@MichiSpandl mind gisting your template code for the menu?

This is my simplified and very reduced code:

<v:page.menu useShortcutData="1" pageUid="{menuPid}" expandAll="1">
    <f:for each="{menu}" as="page">
          <li class="dropdown"><a href="{page.link}">{page.title}</a>
            <v:page.menu useShortcutData="1" pageUid="{page.uid}" expandAll="1">
              <ul class="dropdown-menu">
                <f:for each="{menu}" as="subPage" iteration="iterator">
          <li><a href="{subPage.link}">{subPage.title}</a></li>
        </f:for>
              </ul>
            </v:page.menu>
          </li>
    </f:for>
  </v:page.menu>

In page.uid i have "129" in page.link the value is "/index.php?id=191&MP=191-86".
If i use the "uid", the MP-params are missing in the link. If i use the "link", a complete different menu is rendered (i think the root page is shown in the menu instead of the subpages)...

so where's the error in my thoughts? :)

@MichiSpandl confirmed. Let me have another look.

Hey @bjo3rnf, do you have some news for us? Thanks, Michi

Hi @MichiSpandl,

unfortunately not. At the moment only automatic rendering of complete pagetrees is working. I identified the actual problem but I have no clue (yet) what to do about it and even less time to work on it.

Cheers
Björn

Hey @bjo3rnf!
Are there any news concerning this problem? Have you had time in between for working on it?
Many thanks & best regards,
Michi

This is still not working. Too bad. I guess I have to switch back to a TS menu. Any updates on this?

Please open a new issue if you experience problems - this one has been closed for more than two years now.

Locked.

I'm afraid this is a "won't fix". Even the menu viewhelpers included in FluidStyledContent are unable to handle mountpoints. TS is the way to go here most probably.