[FEATURE] Add an option to exclude certain GET variables in the language menu #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an automated comment based on an automated formal commit review.Your pull request contains formal errors. Comments have been assigned to each commit in your pull request - please review and adjust. Feel free to ask for help if you need it! |
|
Thanks Dmitry - for the feature as well as for fixing our incomplete implementation of the link building ;) Cherry-picked and squashed into development as b07b98e with a nit-pick in CGL amended (space between type cast and variable being cast). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it is necessary to exclude certain GET variables from the generated language link. For example, there can be a parameter to the page, which makes sense only for the current language. Current implementation of the language menu viewhelper does not allow to exclude such variables.
Introduce a new viewhelper parameter named "excludeQueryVars" and use it to exclude parameters if necessary.
Please, note that existing "configuration" parameter cannot be used for this due to the way how variables are added to additionalParams now.