-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow record sliding in page.resources.fal with traits #825
Conversation
} | ||
|
||
/** | ||
* @return \TYPO3\CMS\Extbase\Object\ObjectManagerInterface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@return FluidTYPO3\Vhs\Service\PageSelectService
Damn this looks good. Strike that - damn, this looks really good! I think there's only nit-picking for style and meta-doc and then adjusting the unit tests (and for 1,000 bonus points, a basic test or two to cover the behavior of this trait!). |
Record sliding was traditionally handled solely by content view helpers. It is however desirable to extend sliding support to a greater range of view helpers, most prominently Page\Resources\FalViewHelper. SlideViewHelperTrait implements all functionality commonly required for sliding. Compared to the original implementation in Content\RenderViewHelper, a few changes were introduced: * $limit is now referring to the total number of records, not the number of records rendered per page. This is important when using $slideCollect. * $slideCollect in combination with $slideCollectReverse now selects the correct page range from the rootline when setting it to a value greater than zero. * $slideCollectReverse has no effect when $slideCollect is zero.
This is achieved by utilizing the new functionality introduced by SlideViewHelperTrait. Custom ordering of the records is not supported, but probably also not needed.
The sliding-related code from AbstractContentViewHelper was adopted into SlideViewHelperTrait and thus does not need to be duplicated here.
…cord sliding Content sliding was already supported, but lacked some features. Now it is possible to use $slideCollect and render more than one randomly selected content element by increasing $limit. A change in the inheritance hierarchy was necessary, but should not have any impact on the behaviour.
I've taken care of the meta-doc miss you pointed out. As far as I can see, none of the existing unit tests need to be changed since they don't do much anyway. |
Hi, Personally i would love to drop 5.3 and also use standard array syntax with [] and no extending with [] and definition array(). |
I don't think there's any change from the status quo. |
@pkerling ok, that means we drop 5.3 :) |
Just had a look at ext_emconf.php, 5.3 is gone already since TER version 2.3.0 (see commit d1b732d) |
OK thx :) |
Allow record sliding in page.resources.fal with traits
Thank you so much again, @pkerling - not least for your patience with this one :) |
Continuation from #679 - now with 100% more traits.