Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow record sliding in page.resources.fal with traits #825

Merged
merged 4 commits into from
Aug 8, 2015
Merged

Allow record sliding in page.resources.fal with traits #825

merged 4 commits into from
Aug 8, 2015

Commits on Jun 16, 2015

  1. [FEATURE] Introduce SlideViewHelperTrait 

    Record sliding was traditionally handled solely by content view helpers. It is however desirable to extend sliding support to a greater range of view helpers, most prominently Page\Resources\FalViewHelper.

SlideViewHelperTrait implements all functionality commonly required for sliding.

Compared to the original implementation in Content\RenderViewHelper, a few changes were introduced:
* $limit is now referring to the total number of records, not the number of records rendered per page. This is important when using $slideCollect.
* $slideCollect in combination with $slideCollectReverse now selects the correct page range from the rootline when setting it to a value greater than zero.
* $slideCollectReverse has no effect when $slideCollect is zero.
    @pkerling
    pkerling committed Jun 16, 2015
    Configuration menu
    Copy the full SHA
    b7eb1b3 View commit details
    Browse the repository at this point in the history

  2. [FEATURE] Make Page\Resources\FalViewHelper support record sliding 

    This is achieved by utilizing the new functionality introduced by SlideViewHelperTrait. Custom ordering of the records is not supported, but probably also not needed.
    @pkerling
    pkerling committed Jun 16, 2015
    Configuration menu
    Copy the full SHA
    c078ef0 View commit details
    Browse the repository at this point in the history

  3. [TASK] Make AbstractContentViewHelper use SlideViewHelperTrait 

    The sliding-related code from AbstractContentViewHelper was adopted into SlideViewHelperTrait and thus does not need to be duplicated here.
    @pkerling
    pkerling committed Jun 16, 2015
    Configuration menu
    Copy the full SHA
    e1dae68 View commit details
    Browse the repository at this point in the history

  4. [FEATURE] Adopt Content\Random\GetViewHelper to correctly support re… 

    …cord sliding

Content sliding was already supported, but lacked some features. Now it is possible to use $slideCollect and render more than one randomly selected content element by increasing $limit. A change in the inheritance hierarchy was necessary, but should not have any impact on the behaviour.
    @pkerling
    pkerling committed Jun 16, 2015
    Configuration menu
    Copy the full SHA
    c6d2ce3 View commit details
    Browse the repository at this point in the history