Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO 15897 format of country specific locales #1269

Closed
bjoerne2 opened this issue Jun 24, 2020 · 19 comments
Closed

ISO 15897 format of country specific locales #1269

bjoerne2 opened this issue Jun 24, 2020 · 19 comments
Assignees
@bjoerne2
Milestone
7.0

Comments

@bjoerne2
Copy link

On https://laravel.com/docs/7.x/localization it says:

For languages that differ by territory, you should name the language directories according to the ISO 15897. For example, "en_GB" should be used for British English rather than "en-gb".

Wouldn't it be better to rename the country specific folders, e.g. de-CH -> de_CH?
@caouecs
Copy link
Member

caouecs commented Jun 25, 2020

Good idea, we need to do a new major version ( v7 ), because we brake directory names...

Can you do a pull request ?

bjoerne2 added a commit to bjoerne2/Laravel-lang that referenced this issue Jul 3, 2020
@bjoerne2
Laravel-Lang#1269 Rename locale folders following ISO 15897 format
7b62c30
@bjoerne2 bjoerne2 mentioned this issue Jul 3, 2020
Closed
@bjoerne2
Copy link
Author

bjoerne2 commented Jul 3, 2020

I created a PR: #1276

@caouecs
Copy link
Member

caouecs commented Jul 8, 2020

Can I have references for language names ? As sr_Cyrl

@caouecs caouecs linked a pull request Jul 8, 2020 that will close this issue
#1269 Rename locale folders following ISO 15897 format #1276
Closed
@caouecs caouecs added this to the 7.0 milestone Jul 8, 2020
@caouecs
Copy link
Member

caouecs commented Jul 11, 2020

My problem is for sr_Cyrl, sr_Latn, uz_Cyrl and uz_Latn.

@andrey-helldar
Copy link
Member

andrey-helldar commented Jul 11, 2020 •
edited
Loading

Either I read the technical documentation poorly, or in the description of the ISO 15897:1998 standard there is no mention of the rules for naming language localizations.
Standard ISO 15897:2011 is paid ($168...) 😐

I may be wrong, but I want to propose to call it this way:

de_CH
pt_BR
...
sr_Cyrillic
sr_Latin
uz_Cyrillic
uz_Latin

@caouecs caouecs mentioned this issue Jul 13, 2020
Closed
3 tasks
caouecs added a commit that referenced this issue Jul 13, 2020
@caouecs
feature: #1269 Rename locale folders following ISO 15897 format
2a664c1
@caouecs
Copy link
Member

caouecs commented Jul 13, 2020

done

Thank you

@caouecs caouecs closed this as completed Jul 13, 2020
caouecs added a commit that referenced this issue Jul 14, 2020
@caouecs
fix: #1269 with json files
fe2872f
@overtrue overtrue mentioned this issue Sep 7, 2020
Closed
@milose
Copy link
Contributor

milose commented Nov 24, 2020

If you list the php Intl locales, we have a specific list of locales and the naming should be followed.

 collect(ResourceBundle::getLocales(''))->filter(fn($i) => Str::startsWith($i, 'sr'))
=> Illuminate\Support\Collection {#3268
     all: [
       672 => "sr",
       673 => "sr_Cyrl",
       674 => "sr_Cyrl_BA",
       675 => "sr_Cyrl_ME",
       676 => "sr_Cyrl_RS",
       677 => "sr_Cyrl_XK",
       678 => "sr_Latn",
       679 => "sr_Latn_BA",
       680 => "sr_Latn_ME",
       681 => "sr_Latn_RS",
       682 => "sr_Latn_XK",
     ],
   }

Meaning that sr_Latin, me, etc; locale folders you have are invalid.

Note, I am from Montenegro and I use sr_Latn_ME nomenclature, when I develop.

@andrey-helldar
Copy link
Member

@caouecs, Since the ISO 15897:2011 standard does not regulate the naming of these localizations, I think @milose's proposal is reasonable.

@caouecs
Copy link
Member

caouecs commented Nov 25, 2020

no problem for me

@andrey-helldar andrey-helldar mentioned this issue Nov 25, 2020
Merged
@andrey-helldar
Copy link
Member

no problem for me

I created a PR #1453, but @LukaLatkovic must review, since he is referent for the sr_* languages.

@LukaLatkovic
Copy link
Member

LukaLatkovic commented Nov 26, 2020 •
edited
Loading

So, that means that me folder should be renamed to sr_Latn_ME

@LukaLatkovic
Copy link
Member

LukaLatkovic commented Nov 26, 2020 •
edited
Loading

@caouecs, Since the ISO 15897:2011 standard does not regulate the naming of these localizations, I think @milose's proposal is reasonable.

This proposal is done by Unicode standard(International Components for Unicode), so maybe we can do locales based on that standard List of all locales by Unicode, Simple search since Php Intl is based on that
@caouecs, @andrey-helldar what do you think?

@milose
Copy link
Contributor

milose commented Nov 26, 2020

We are web developers here and this is a Laravel oriented package. With this I mean to say that the directory of the locale should be named in a way so it can be consumed app()->getLocale() method.

Laravel workflow is:

  1. you set the 'locale' in app.php
  2. you use the <html lang="{{ str_replace('_', '-', app()->getLocale()) }}"> to set the language contained in your HTML output (important for search engines, automatic translations, screen readers etc.
  3. you consume other packages with the correct locales like Carbon (their Lang folder) with ease.

Introducing other names, that are not standardised on the web means we need to "translate" locale names for other packages, html attributes etc. This is not ideal and the correct nomenclature should be used.

BTW, the translation for Montenegrin language is atrocious. I will make a pull request for the correct translation after this is resolved.

@andrey-helldar
Copy link
Member

andrey-helldar commented Nov 27, 2020 •
edited
Loading

@caouecs, Since the ISO 15897:2011 standard does not regulate the naming of these localizations, I think @milose's proposal is reasonable.

This proposal is done by Unicode standard(International Components for Unicode), so maybe we can do locales based on that standard List of all locales by Unicode, Simple search since Php Intl is based on that
@caouecs, @andrey-helldar what do you think?

Taylor introduced the ISO 15897:2011 standard into the framework and I think we don't need to violate it.

If proposals for adjustments do not contradict him, then they can be considered.

@milose
Copy link
Contributor

milose commented Nov 27, 2020 •
edited
Loading

Taylor introduced the ISO 15897:2011 standard into the framework and I think we don't need to violate it.

Sauce, please? @andrey-helldar

@andrey-helldar
Copy link
Member

andrey-helldar commented Nov 27, 2020 •
edited
Loading

Taylor introduced the ISO 15897:2011 standard into the framework and I think we don't need to violate it.

Sauce, please? @andrey-helldar

You mean proof?

image

And my PR: #1453

@milose
Copy link
Contributor

milose commented Nov 30, 2020

Thanks @andrey-helldar I missed that.

@andrey-helldar
Copy link
Member

@milose, a few days ago, we released a new major version of the package taking into account these changes.
You can independently monitor the update of files in your project or use a manager. For example, this one.

@caouecs
Copy link
Member

caouecs commented Dec 4, 2020

@milose, a few days ago, we released a new major version of the package taking into account these changes.
You can independently monitor the update of files in your project or use a manager. For example, this one.

for example... ;)

@xiaomlove xiaomlove mentioned this issue Feb 18, 2021
Closed
@aczyt aczyt mentioned this issue Jan 9, 2022
Closed
@nvasic88 nvasic88 mentioned this issue Apr 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjoerne2 bjoerne2

Labels
None yet
Milestone
7.0
Development

Successfully merging a pull request may close this issue.

#1269 Rename locale folders following ISO 15897 format bjoerne2/Laravel-lang
5 participants
@caouecs @bjoerne2 @milose @andrey-helldar @LukaLatkovic