-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete the progress bar rendering in Invoke-WebRequest
when downloading is complete or cancelled
#18130
Conversation
…oading is successful or cancelled
src/Microsoft.PowerShell.Commands.Utility/resources/WebCmdletStrings.resx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
PR Summary
Complete the progress bar rendering in
Invoke-WebRequest
when downloading is successful or cancelled.The
WriteToStream
method doesn't complete the progress bar rendering when the download is complete or cancelled, and this causes the progress bar to linger around and hide the output from external commands that runs right afterInvoke-WebRequest
.Old behavior
Note that, the string
This is a string
written by[Console]::WriteLine
is not displayed after execution:New behavior
Note that, the string
This is a string
is displayed after execution as expected:PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.