-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parsing to make cd~ a valid command. #18308
Conversation
Should we document this? |
$ParentDir = 'TestDrive:\' | ||
New-Item -Path 'TestDrive:\' -Name 'Directory1' -ItemType Directory | ||
Set-Location 'TestDrive:\Directory1' | ||
cd.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we a test for cd\
? Please add if no.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one comment.
test/powershell/Modules/Microsoft.PowerShell.Management/Set-Location.Tests.ps1
Show resolved
Hide resolved
Can you please associate the development of this with the issue #17140 so I can get my free internet points for Hacktoberfest? 🍺thanks. |
@sdwheeler Should we document this? |
Yes, please file a doc issue. We document those functions in |
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@SteveL-MSFT Tests were added. Please take another look when you have a chance. |
PR Summary
cd..
andcd\\
currently automatically parse toSet-Location ..
andSet-Location \\
respectively. This PR allows the same behavior forcd~
.PR Context
Resolves issue #17140
PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).