Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip VT100 tests on Windows Server 2012R2 as console does not support it #19413

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Skip VT100 tests on Windows Server 2012R2 as console does not support it #19413

merged 3 commits into from
Mar 28, 2023

Conversation

adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Mar 27, 2023 •
edited
Loading

PR Summary

Skip tests on Windows Server 2012R2 which require VT100 console support

PR Context

PR Checklist

@ghost ghost assigned PaulHigin Mar 27, 2023
@pull-request-quantifier-deprecated
Copy link

This PR has 10 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +8 -2
Percentile : 4%

Total files changed: 3

Change summary by file extension:
.ps1 : +8 -2

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@adityapatwardhan adityapatwardhan enabled auto-merge (squash) March 27, 2023 22:33
@adityapatwardhan adityapatwardhan added CL-Test Indicates that a PR should be marked as a test change in the Change Log Backport-7.2.x-Consider Backport-7.3.x-Consider labels Mar 27, 2023
@adityapatwardhan adityapatwardhan enabled auto-merge (squash) March 28, 2023 00:35
@adityapatwardhan adityapatwardhan merged commit 5a22587 into PowerShell:master Mar 28, 2023
@adityapatwardhan adityapatwardhan deleted the FixWin20212R2VT100 branch March 28, 2023 16:36
dwtaber pushed a commit to dwtaber/PowerShell that referenced this pull request Mar 29, 2023
@adityapatwardhan @dwtaber
Skip VT100 tests on Windows Server 2012R2 as console does not support…
cef5237 
… it (PowerShell#19413)
CarloToso pushed a commit to CarloToso/PowerShell that referenced this pull request Apr 8, 2023
@stevenebutler
Pr/19379 (#1)
1a6707d 
* Remove FormObject.cs and FormObjectCollection.cs (PowerShell#19383)

* Exclude redundant parameter aliases from completion results (PowerShell#19382)

* Revert "Remove FormObject.cs and FormObjectCollection.cs (PowerShell#19383)" (PowerShell#19387)

This reverts commit 190c99a.

* Add the parameter `-RelativeBasePath` to `Resolve-Path` (PowerShell#19358)

* Fix a crash in the type inference code (PowerShell#19400)

* Remove GetResponseObject (PowerShell#19380)

* Add `-Environment` parameter to `Start-Process` (PowerShell#19374)

* Add `-Environment` parameter to `Start-Process`

* address codefactor

* fix test for Windows

* handle case where value is $null to remove env var

* change variables to make it more clear what the test is doing

* Add PoolNames variable group to compliance pipeline (PowerShell#19408)

* Improve package management acceptance tests by not going to the gallery (PowerShell#19412)

* Skip VT100 tests on Windows Server 2012R2 as console does not support it (PowerShell#19413)

* Update the `ICommandPredictor` interface to reduce boilerplate code from predictor implementation (PowerShell#19414)

* Enable type conversion of `AutomationNull` to `$null` for assignment (PowerShell#19415)

* Remove code related to `#requires -pssnapin` (PowerShell#19320)

* Support CTRL-C when reading data and connection hangs for `Invoke-RestMethod` and `Invoke-WebRequest` (PowerShell#19330)

* Update to the latest NOTICES file (PowerShell#19332)

* Update the cgmanifest (PowerShell#19459)

* WIP: Harden default command test. (PowerShell#19416)
daxian-dbw pushed a commit to daxian-dbw/PowerShell that referenced this pull request Apr 12, 2023
@adityapatwardhan @daxian-dbw
Skip VT100 tests on Windows Server 2012R2 as console does not support…
8450602 
… it (PowerShell#19413)
@ghost
Copy link

ghost commented Apr 13, 2023

🎉v7.2.11 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Apr 13, 2023

🎉v7.3.4 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Apr 20, 2023

🎉v7.4.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

adityapatwardhan added a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 25, 2023
@adityapatwardhan @daxian-dbw
Skip VT100 tests on Windows Server 2012R2 as console does not support…
980b165 
… it (PowerShell#19413)
@TravisEz13 TravisEz13 mentioned this pull request Apr 16, 2024
Closed
@TravisEz13 TravisEz13 mentioned this pull request Jul 9, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesWTruher JamesWTruher JamesWTruher approved these changes

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

Assignees

@PaulHigin PaulHigin

Labels
Backport-7.2.x-Done Backport-7.3.x-Done CL-Test Indicates that a PR should be marked as a test change in the Change Log Extra Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adityapatwardhan @JamesWTruher @SteveL-MSFT @daxian-dbw @PaulHigin