Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devcontainers: mount workspace in /PowerShell #23857

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

rzippo
Copy link
Contributor

@rzippo rzippo commented May 27, 2024

PR Summary

This PR fixes #23854.
To build packages, Start-PSPackage expects the repository to be at /Powershell, but devcontainers mount it by default at /workspaces/name-of-the-folder.
This fix configures the devcontainers to mount the workspace at /Powershell, so that Start-PSPackage works as expected.

The fix was tested by building a 7.4.2 package on the Ubuntu 18.04 devcontainer (see this branch).

PR Context

PR Checklist

@rzippo
Copy link
Contributor Author

rzippo commented May 27, 2024

@microsoft-github-policy-service agree

Copy link
Collaborator

@kilasuit kilasuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fedora is not supported by PowerShell anymore
Update to a supported version of Ubuntu
@TravisEz13 TravisEz13 merged commit 2b64ee6 into PowerShell:master Jul 31, 2024
37 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Review - Needed The PR is being reviewed label Jul 31, 2024
@TravisEz13 TravisEz13 added Review - Needed The PR is being reviewed CL-Tools Indicates that a PR should be marked as a tools change in the Change Log labels Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-Tools Indicates that a PR should be marked as a tools change in the Change Log Review - Needed The PR is being reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot build packages from devcontainer
3 participants