Refactor Button component to handle icon visibility #10891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the Button component to handle the visibility of the icon. The code changes include: - Adding the `component` prop to the `Button` component to access the `iconVisibility` value from the component definition styles. - Updating the condition for rendering the icon based on the `iconVisibility.value` property. The `Button` component is now able to properly handle the visibility of the icon.
Code Review Agent Run Status
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10936
This pull request includes several changes to the
Buttoncomponent in thefrontend/src/Editor/Components/Button.jsxfile and updates to thebuttonConfiginfrontend/src/Editor/WidgetManager/configs/button.js. The changes primarily focus on refactoring the code and improving how theiconVisibilityproperty is handled.Changes to
Buttoncomponent:componentto the destructured props in theButtoncomponent. (frontend/src/Editor/Components/Button.jsx)iconVisibilityfromstylestocomponent?.definition?.styles. (frontend/src/Editor/Components/Button.jsx)iconVisibility.valueinstead oficonVisibility. (frontend/src/Editor/Components/Button.jsx)Changes to
buttonConfig:visibilityproperty from theiconconfiguration. (frontend/src/Editor/WidgetManager/configs/button.js)This commit refactors the Button component to handle the visibility of the icon. The code changes include:componentprop to theButtoncomponent to access theiconVisibilityvalue from the component definition styles.iconVisibility.valueproperty.The
Buttoncomponent is now able to properly handle the visibility of the icon.Attachments