Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated spinner.md #10931

Closed

Conversation

lakshita10341
Copy link

i have done the changes. please verify it

@CLAassistant
Copy link

CLAassistant commented Oct 10, 2024

CLA assistant check
All committers have signed the CLA.

@TooljetBot
Copy link
Collaborator

Code Review Agent Run Status

  • Limitations and other issues: The AI Code Review Agent was unable to review this change because Bito workspace ToolJet is downgraded to the plan that doesn’t include Code Review Agent feature.

    Please coordinate with your workspace admin to request an upgrade to the 10X Developer Plan.

Copy link

sonarcloud bot commented Oct 10, 2024


## Layout

| <div style={{ width:"100px"}}> Layout </div> | <div style={{ width:"100px"}}> Description </div> | <div style={{ width:"135px"}}> Expected Value </div> |
|:--------------- |:----------------------------------------- | :------------------------------------------------------------------------------------------------------------- |
| Show on desktop | Toggle on or off to display desktop view. | You can programmatically determining the value by clicking on `Fx` to set the value `{{true}}` or `{{false}}` |
| Show on mobile | Toggle on or off to display mobile view. | You can programmatically determining the value by clicking on `Fx` to set the value `{{true}}` or `{{false}}` |
| Show on desktop | Toggle on or off to display desktop view. | You can programmatically determining the value by clicking on `fx` to set the value `{{true}}` or `{{false}}` |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lakshita10341, the fx should be in bold and not enclosed in back tick, can you please make this change in the whole doc and both versions where ever applicable.

| Show on desktop | Toggle on or off to display desktop view. | You can programmatically determining the value by clicking on `Fx` to set the value `{{true}}` or `{{false}}` |
| Show on mobile | Toggle on or off to display mobile view. | You can programmatically determining the value by clicking on `Fx` to set the value `{{true}}` or `{{false}}` |
| Show on desktop | Toggle on or off to display desktop view. | You can programmatically determining the value by clicking on `fx` to set the value `{{true}}` or `{{false}}` |
| Show on mobile | Toggle on or off to display mobile view. | You can programmatically determining the value by clicking on `fx` to set the value `{{true}}` or `{{false}}` |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also add a full stop at the end of sentence here? Please do this for both the sentence in the table and in both versions.

@PriteshKiri
Copy link
Collaborator

Hey @lakshita10341,

Can you please make the changes asked by @RudraPratik30 ?

@RudraPratik30
Copy link
Collaborator

Hey @lakshita10341!
Closing this PR due to lack of progress.

@lakshita10341
Copy link
Author

Hi @PriteshKiri
I have done the changes which was said earlier and the PR was merged. Sorry for not replying on above suggested changes because I was busy that time somewhere else. So didn't see the mail. But now it is showing my pr is not merged which was merged earlier.
Can this issue be resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants