-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated spinner.md #10931
updated spinner.md #10931
Conversation
Code Review Agent Run Status
|
Quality Gate passedIssues Measures |
|
||
## Layout | ||
|
||
| <div style={{ width:"100px"}}> Layout </div> | <div style={{ width:"100px"}}> Description </div> | <div style={{ width:"135px"}}> Expected Value </div> | | ||
|:--------------- |:----------------------------------------- | :------------------------------------------------------------------------------------------------------------- | | ||
| Show on desktop | Toggle on or off to display desktop view. | You can programmatically determining the value by clicking on `Fx` to set the value `{{true}}` or `{{false}}` | | ||
| Show on mobile | Toggle on or off to display mobile view. | You can programmatically determining the value by clicking on `Fx` to set the value `{{true}}` or `{{false}}` | | ||
| Show on desktop | Toggle on or off to display desktop view. | You can programmatically determining the value by clicking on `fx` to set the value `{{true}}` or `{{false}}` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lakshita10341, the fx should be in bold and not enclosed in back tick, can you please make this change in the whole doc and both versions where ever applicable.
| Show on desktop | Toggle on or off to display desktop view. | You can programmatically determining the value by clicking on `Fx` to set the value `{{true}}` or `{{false}}` | | ||
| Show on mobile | Toggle on or off to display mobile view. | You can programmatically determining the value by clicking on `Fx` to set the value `{{true}}` or `{{false}}` | | ||
| Show on desktop | Toggle on or off to display desktop view. | You can programmatically determining the value by clicking on `fx` to set the value `{{true}}` or `{{false}}` | | ||
| Show on mobile | Toggle on or off to display mobile view. | You can programmatically determining the value by clicking on `fx` to set the value `{{true}}` or `{{false}}` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please also add a full stop at the end of sentence here? Please do this for both the sentence in the table and in both versions.
Hey @lakshita10341, Can you please make the changes asked by @RudraPratik30 ? |
Hey @lakshita10341! |
Hi @PriteshKiri |
i have done the changes. please verify it