Refactor LeftSidebarPageSelector component and JSONTreeViewer component #10933
+544
−296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor LeftSidebarPageSelector component to include additional props: jsonData, iconsList, actionsList, and selectedComponent. - Refactor JSONTreeViewer component to include additional prop: pageTree. - Clean up the data in JSONTreeObjectNode component. - Update styles in components.scss file.
Code Review Agent Run Status
|
Code Review Agent Run Status
|
Code Review Agent Run Status
|
Code Review Agent Run Status
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10935
Component Updates:
frontend/src/Editor/LeftSidebar/SidebarPageSelector/PageHandler.jsx: Updated the component to includeJSONTreeViewerand refactored the rendering logic for better readability and maintainability. [1] [2] [3] [4] [5] [6]State Management Refactor:
frontend/src/Editor/LeftSidebar/SidebarInspector.jsx: Removed redundant state management and memoization logic, and updated the component to receivejsonData,iconsList,actionsList, andselectedComponentas props. [1] [2] [3]PropTypes Addition:
frontend/src/Editor/LeftSidebar/SidebarPageSelector/PageHandler.jsx: Added PropTypes forPageHandlerandAddingPageHandlercomponents to ensure proper type checking of props.Import and State Cleanup:
frontend/src/Editor/LeftSidebar/index.jsx: Added necessary imports and cleaned up state management by removing unused states and consolidating data sources. [1] [2] [3]Prop Drilling:
frontend/src/Editor/LeftSidebar/SidebarPageSelector/index.jsx: Passed down additional props (jsonData,iconsList,actionsList,selectedComponent) toPageHandlercomponent for better state management. [1] [2]Attachments: