fix(docs): Made the suggested changes for Start Rating component #10943
+40
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Review Agent Run Status
|
|
|
RudraPratik30
requested changes
Oct 11, 2024
docs/docs/widgets/star-rating.md
Outdated
|
|
||
| ## Layout | ||
|
|
||
| | <div style={{ width:"100px"}}> Layout </div> | <div style={{ width:"100px"}}> Description </div> | <div style={{ width:"135px"}}> Expected Value </div> | | ||
| |:--------------- |:----------------------------------------- | :------------------------------------------------------------------------------------------------------------- | | ||
| | Show on desktop | Toggle on or off to display desktop view. | You can programmatically determining the value by clicking on `Fx` to set the value `{{true}}` or `{{false}}` | | ||
| | Show on mobile | Toggle on or off to display mobile view. | You can programmatically determining the value by clicking on `Fx` to set the value `{{true}}` or `{{false}}` | | ||
| | Show on desktop | Toggle on or off to display desktop view. | You can programmatically determining the value by clicking on **`fx`** to set the value `{{true}}` or `{{false}}` | |
There was a problem hiding this comment.
Hey @OlibhiaGhosh can you please add a full stop at the end of the sentence here? Please do it for both the sentence in the table and both versions. Also please check this issue in the rest of doc as well.
There was a problem hiding this comment.
I added full stop at every possible sentence wherever applicable.
docs/docs/widgets/star-rating.md
Outdated
|
|
||
| ## Layout | ||
|
|
||
| | <div style={{ width:"100px"}}> Layout </div> | <div style={{ width:"100px"}}> Description </div> | <div style={{ width:"135px"}}> Expected Value </div> | | ||
| |:--------------- |:----------------------------------------- | :------------------------------------------------------------------------------------------------------------- | | ||
| | Show on desktop | Toggle on or off to display desktop view. | You can programmatically determining the value by clicking on `Fx` to set the value `{{true}}` or `{{false}}` | | ||
| | Show on mobile | Toggle on or off to display mobile view. | You can programmatically determining the value by clicking on `Fx` to set the value `{{true}}` or `{{false}}` | | ||
| | Show on desktop | Toggle on or off to display desktop view. | You can programmatically determining the value by clicking on **`fx`** to set the value `{{true}}` or `{{false}}` | |
There was a problem hiding this comment.
fx should be bold only and not enclosed in the backtick. Please change it in the whole doc and both versions wherever applicable.
RudraPratik30
requested changes
Oct 11, 2024
docs/docs/widgets/star-rating.md
Outdated
| <div style={{paddingTop:'24px', paddingBottom:'24px'}}> | ||
| <div style={{paddingTop:'24px'}}> | ||
|
|
||
| --- | ||
|
|
||
| ## Styles | ||
|
|
||
| | <div style={{ width:"100px"}}> Style </div> | <div style={{ width:"100px"}}> Description </div> | <div style={{ width:"100px"}}> Default Value </div> | | ||
| |:------------ |:-------------|:--------- | | ||
| | Star Color | Display color of the star. `default: #ffb400` (color hex). Change color by providing `Hex color code` or choosing one from the picker. | | |
There was a problem hiding this comment.
Can you please add the default value here in the default value column? And Please remove the default value from description column.
Code Review Agent Run Status
|
Code Review Agent Run Status
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made the following changes:
divthat wraps up the h2 headers and the section below the headerI have made all these changes in both the asked files.
Issue: #10925