add mod path suffix to release as v5.x.x #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
これマージした後に v5.8.6 あたりをリリースすることでやっととれるはずです。 |
|
あざます。これ go-sqlite3 にも言える話ですね... |
johejo
added a commit
to johejo/jvgrep
that referenced
this pull request
Jun 14, 2020
related mattn#76
Merged
johejo
added a commit
to johejo/jvgrep
that referenced
this pull request
Jun 14, 2020
related mattn#76
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v5.8.2 以降 module enabled で go get すると v5.8.1 が振ってくるのを直せるはずの修正です。
無理矢理 v5.8.5 (最新) を module enabled で持ってこようとすると
こんな感じで怒られます。
なんでかなって調べてみたら v2 以降をリリースする場合は
module path に
/v2もしくは.v2の suffix が要るっぽいです。ただココに置くのが正しいのかは実際にやってみないとちょっとわかりません。