Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always getting "Couldn't start client Language Server" in Insiders under F5 #55907

Closed
StephenWeatherford opened this issue Aug 6, 2018 · 8 comments
Closed

Always getting "Couldn't start client Language Server" in Insiders under F5 #55907

StephenWeatherford opened this issue Aug 6, 2018 · 8 comments
Assignees
@roblourens @Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Milestone
July 2018

Comments

@StephenWeatherford
Copy link

Issue Type: Bug

See microsoft/vscode-docker#357.
This is recent behavior and doesn't seem to be related to any changes made on our side. Seems to only happen in Insiders and only when running the extension under F5. And seems to happen 100%.

REPRO:

  1. git clone https://github.com/Microsoft/vscode-docker.git
  2. npm install
  3. open folder in vscode
  4. F5
  5. In extension host, click on Docker icon:
    image
    !) Error: Couldn't start client Dockerfile Language Server

VS Code version: Code - Insiders 1.26.0-insider (4fa62b2, 2018-08-03T12:32:37.823Z)
OS version: Windows_NT x64 10.0.17134

System Info
Item Value
CPUs Intel(R) Xeon(R) CPU E31230 @ 3.20GHz (4 x 3193)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 15.96GB (3.34GB free)
Process Argv C:\Users\stephwe\AppData\Local\Programs\Microsoft VS Code Insiders\Code - Insiders.exe c:\Repos\vscode-docker
Screen Reader no
VM 0%
Extensions (10)
Extension Author (truncated) Version
vscode-markdownlint Dav 0.19.0
vscode-eslint dba 1.4.12
tslint eg2 1.0.34
rest-client hum 0.19.0
csharpfixformat Leo 0.0.73
vscode-mocha-sidebar mat 0.20.17
vscode-antlr4 mik 2.0.4
vscode-language-pack-de MS- 1.26.1
azure-account ms- 0.4.3
vscode-docker Pet 0.1.0
@vscodebot vscodebot bot added the insiders label Aug 6, 2018
@ramya-rao-a
Copy link
Contributor

@dbaeumer @aeschli I could trace this down to electron.fork failing at https://github.com/Microsoft/vscode-languageserver-node/blob/7700442d2580957ce5c8b40de7f2f50f837ef755/client/src/main.ts#L353 with code 9.

@ramya-rao-a ramya-rao-a added the candidate Issue identified as probable candidate for fixing in the next release label Aug 6, 2018
@ramya-rao-a
Copy link
Contributor

cc @bpasero and @Tyriar as this might be related to electron

@ramya-rao-a ramya-rao-a added this to the July 2018 milestone Aug 6, 2018
@ramya-rao-a
Copy link
Contributor

@roblourens looked into this further and we found that changing the debug to inspect at https://github.com/Microsoft/vscode-docker/blob/069ed857323f4ceadfcee33130815c9d3fd56584/dockerExtension.ts#L213 fixes the issue.

This is due to the electron update we did for VS Code 1.26

@roblourens @weinand We can either update the documentation and release notes or maintain backward compatibility. Leaving this up to you.

@ramya-rao-a ramya-rao-a assigned roblourens and weinand and unassigned dbaeumer and aeschli Aug 6, 2018
@weinand
Copy link
Contributor

weinand commented Aug 6, 2018 •
edited
Loading

In the release notes we need to add in the Electron update section that the new node version no longer supports the legacy debug protocol and the (—debug argument).

@weinand weinand assigned Tyriar and unassigned weinand Aug 6, 2018
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Aug 7, 2018
@joaomoreno
Copy link
Member

As discussed, @Tyriar let's release note this, due to the Electron update.

@StephenWeatherford
Copy link
Author

Great, thanks!

@Tyriar
Copy link
Member

Tyriar commented Aug 7, 2018

I'll add it to the section now

Tyriar added a commit to microsoft/vscode-docs that referenced this issue Aug 7, 2018
@Tyriar
Add note about node dropping debug protocol and natives module
47f7f37 
Fixes microsoft/vscode#55907
@Tyriar
Copy link
Member

Tyriar commented Aug 7, 2018

Added, I also called out the natives module microsoft/vscode-docs@47f7f37

@Tyriar Tyriar closed this as completed Aug 7, 2018
@chrmarti chrmarti added the verified Verification succeeded label Aug 8, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Projects
None yet
Milestone
July 2018
Development

No branches or pull requests
11 participants
@joaomoreno @roblourens @bpasero @weinand @dbaeumer @Tyriar @aeschli @StephenWeatherford @chrmarti @ramya-rao-a and others