Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: replace electron File.path with electron webUtils #213031

Merged
merged 66 commits into from
Jun 2, 2024
Merged

feature: replace electron File.path with electron webUtils #213031

Changes from 1 commit
Commits
Show all changes
66 commits
Select commit Hold shift + click to select a range
985fb67
add getPathForFIle function
SimonSiefke May 19, 2024
ac78e5e
use electron webutils
SimonSiefke May 19, 2024
0f3f58a
use webutils
SimonSiefke May 19, 2024
e0c93e5
use getPathForFile
SimonSiefke May 19, 2024
929df81
add test
SimonSiefke May 19, 2024
4fbae2e
fix import
SimonSiefke May 19, 2024
ff2218d
add web utils service
SimonSiefke May 19, 2024
96ae74c
register electron webutils service
SimonSiefke May 19, 2024
7c43216
register contribution
SimonSiefke May 19, 2024
4a5e2e9
import contribution
SimonSiefke May 19, 2024
9a078e6
register web contribution
SimonSiefke May 19, 2024
0cf8c39
feature: use webUtils service to not directly depend on electron global
SimonSiefke May 19, 2024
e693bbd
use webutils service for terminal
SimonSiefke May 19, 2024
a452548
update imports
SimonSiefke May 19, 2024
66a0c63
tsc
SimonSiefke May 19, 2024
4cc1763
update imports
SimonSiefke May 19, 2024
c3dd4bb
add servicebrand
SimonSiefke May 19, 2024
6f1d793
tsc
SimonSiefke May 19, 2024
7a82910
tsc
SimonSiefke May 20, 2024
898dc09
try different approach
SimonSiefke May 22, 2024
37d1828
add class and subclass
SimonSiefke May 22, 2024
ab25760
register contribution with subclass
SimonSiefke May 22, 2024
52bfe40
rename function
SimonSiefke May 22, 2024
f85adf9
remove web utils service
SimonSiefke May 22, 2024
fc0d103
register getPathForFile function
SimonSiefke May 22, 2024
11c6205
fix import
SimonSiefke May 22, 2024
8a16f90
remove webutils service
SimonSiefke May 22, 2024
454d277
remove import
SimonSiefke May 22, 2024
acab5b8
remove import
SimonSiefke May 22, 2024
76bdb9f
fix imports
SimonSiefke May 22, 2024
1f2fcd4
fix import
SimonSiefke May 22, 2024
5715fe9
fix overwriting view
SimonSiefke May 22, 2024
5434626
register method
SimonSiefke May 22, 2024
84e2f16
fix import
SimonSiefke May 22, 2024
dbd1b73
register contribution
SimonSiefke May 22, 2024
107a8ae
don't overwrite electron service with browser service
SimonSiefke May 22, 2024
9e9ac95
remove log
SimonSiefke May 22, 2024
b01cb05
remove log
SimonSiefke May 22, 2024
3b610af
tsc
SimonSiefke May 22, 2024
3537e32
Merge remote-tracking branch 'origin/main' into feature/web-utils-get…
SimonSiefke May 22, 2024
a47f7af
Discard changes to src/vs/workbench/contrib/files/browser/fileActions…
SimonSiefke May 30, 2024
129bd11
Discard changes to src/vs/workbench/contrib/files/browser/fileActions.ts
SimonSiefke May 30, 2024
4a71cc7
Discard changes to src/vs/workbench/contrib/files/electron-sandbox/fi…
SimonSiefke May 30, 2024
3b6069f
Discard changes to src/vs/workbench/contrib/terminal/browser/terminal…
SimonSiefke May 30, 2024
9de6e87
Discard changes to src/vs/workbench/contrib/terminal/browser/terminal.ts
SimonSiefke May 30, 2024
60b66d1
Discard changes to src/vs/workbench/contrib/terminal/browser/terminal…
SimonSiefke May 30, 2024
871d41f
Discard changes to src/vs/workbench/contrib/terminal/browser/terminal…
SimonSiefke May 30, 2024
9c7c28b
Discard changes to src/vs/workbench/contrib/terminal/browser/terminal…
SimonSiefke May 30, 2024
9bba31b
Discard changes to src/vs/workbench/contrib/terminal/browser/terminal…
SimonSiefke May 30, 2024
86463ad
Discard changes to src/vs/workbench/contrib/terminal/browser/terminal…
SimonSiefke May 30, 2024
18e0a4d
Discard changes to src/vs/workbench/contrib/terminal/electron-sandbox…
SimonSiefke May 30, 2024
5a6b1e4
Discard changes to src/vs/workbench/contrib/terminal/electron-sandbox…
SimonSiefke May 30, 2024
103f256
Discard changes to src/vs/workbench/contrib/terminal/electron-sandbox…
SimonSiefke May 30, 2024
c3bb695
Discard changes to src/vs/workbench/contrib/terminal/test/browser/ter…
SimonSiefke May 30, 2024
9401ba0
add function to interface
SimonSiefke May 30, 2024
7156141
add function
SimonSiefke May 30, 2024
02377f2
use host service
SimonSiefke May 30, 2024
85251f0
use host service in terminal tabs list
SimonSiefke May 30, 2024
818efe5
use host service in terminal instance
SimonSiefke May 30, 2024
ef44623
remove unused code
SimonSiefke May 30, 2024
5f9e5b9
fix imports
SimonSiefke May 30, 2024
a17a6d4
replace remaining usages of file path
SimonSiefke May 30, 2024
cad1f17
Merge branch 'main' into feature/web-utils-get-path-for-file
SimonSiefke May 30, 2024
9bd9eb6
tsc
SimonSiefke May 30, 2024
e345ebd
add semicolon
SimonSiefke May 30, 2024
c0298e5
cleanup
bpasero May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unused code
  • Loading branch information
@SimonSiefke
SimonSiefke committed May 30, 2024
commit ef44623be41f942ef65fc2fdd65e7a23615f05ce
1 change: 0 additions & 1 deletion src/vs/workbench/contrib/terminal/browser/terminalInstance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,6 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {
@ICommandService private readonly _commandService: ICommandService,
@IAccessibilitySignalService private readonly _accessibilitySignalService: IAccessibilitySignalService,
@IViewDescriptorService private readonly _viewDescriptorService: IViewDescriptorService,
@IHostService private readonly _hostService: IHostService,
) {
super();

Expand Down