Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed App Update UX & Made Auto Updates Opt-In #1575

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Changed App Update UX & Made Auto Updates Opt-In #1575

merged 1 commit into from
Jun 6, 2019

Conversation

tonyanziano
Copy link
Contributor

@tonyanziano tonyanziano commented May 14, 2019 •
edited
Loading

Resolves #1408

===

Tests are WIP

This PR includes the following changes to app update logic:

  1. Auto update must be explicitly opted into now
  2. The app will always check for updates on startup, regardless of auto update or not
  3. If there are updates, and auto update is not enabled, the following modal will be shown:

image

(option 2 is always selected by default, and option 3 will enable auto updates)

Light

image

Dark

image

High Contrast

image

@tonyanziano tonyanziano marked this pull request as ready for review May 15, 2019 00:01
@cwhitten cwhitten changed the title Toanzian/update #1408 [HOLD] toanzian/update #1408 May 15, 2019
@tonyanziano tonyanziano changed the title [HOLD] toanzian/update #1408 [HOLD] Changed App Update UX & Made Auto Updates Opt-In May 15, 2019
@tonyanziano tonyanziano force-pushed the toanzian/update-#1408 branch 2 times, most recently from b5d4472 to ca122a2 Compare June 5, 2019 23:07
@tonyanziano tonyanziano changed the title [HOLD] Changed App Update UX & Made Auto Updates Opt-In Changed App Update UX & Made Auto Updates Opt-In Jun 6, 2019
@cwhitten cwhitten merged commit abd94f7 into master Jun 6, 2019
@cwhitten cwhitten deleted the toanzian/update-#1408 branch June 6, 2019 20:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@compulim compulim Awaiting requested review from compulim

@corinagum corinagum Awaiting requested review from corinagum

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Telemetry Compliance] Make auto update opt-in
2 participants
@tonyanziano @cwhitten