Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed some minor styling issues with the JSON inspector. #1691

Merged
merged 2 commits into from
Jul 17, 2019
Merged

Fixed some minor styling issues with the JSON inspector. #1691

merged 2 commits into from
Jul 17, 2019

Conversation

tonyanziano
Copy link
Contributor

@tonyanziano tonyanziano commented Jul 16, 2019 •
edited
Loading

List of changes:

  • swapped out previous & next diff icons with flat icons that don't have drop-shadows
    • (also got rid of left-arrow svg in favor of rotating the right-arrow)
  • changed header for JSON inspector from "Json" -> "JSON"
  • changed casing of "Show Diff" & "Hide Diff" -> "Show diff" & "Hide diff"
  • JSON header now always has "active" or "selected" styling so the blue underline doesn't go away when toggling the show / hide diff button
  • syntax highlighting should now work again for the JSON tree when in diff mode

Before:

image

After:

image

@cwhitten cwhitten merged commit fc36309 into master Jul 17, 2019
@cwhitten cwhitten deleted the toanzian/inspector-fixes branch July 17, 2019 17:11
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@compulim compulim Awaiting requested review from compulim

@corinagum corinagum Awaiting requested review from corinagum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonyanziano @cwhitten