Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#1910][MAS4.2.10][Focus Order - Connect the bot] In JSON tab, the focus goes on the hidden controls #1982

Merged
merged 2 commits into from
Nov 13, 2019

Conversation

denscollo
Copy link
Contributor

Solves #1910

Description

Fixes how the focus goes to the three hidden buttons on the JSON Inspector pane.

Changes made

In the Inspector component, we added two attributes to the accessory buttons when these are disabled. These attributes are TabIndex=-1 and aria-hidden=true. This way, the focus won't go to these buttons while they are disabled, only in Debug Mode when they get enabled.

Additionally, we noticed that this issue was happening on windows as well. The same solution applies to the three platforms, Windows, MacOS, and Linux.

Testing

In the following images, you can see how the focus goes to the accessory buttons only in Debug Mode when they are enabled:

image

image

Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@tonyanziano tonyanziano merged commit cb8b890 into master Nov 13, 2019
@tonyanziano tonyanziano deleted the fix/focus-going-hidden-buttons branch November 13, 2019 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants