Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1913] Fixed a11y issue with json viewer component. #2009

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

tonyanziano
Copy link
Contributor

#1913

===

The root node <ul> of the collapsible JSON viewer component was being assigned a tabindex of 0, which was making the root of the tree focusable which was unnecessary. On Mac, this would read as "Empty table," which is not useful information for users relying on a screen reader.

I have removed this attribute from the root node, and the component remains keyboard accessible without relaying any irrelevant information.

(Tested on Windows as well, and a11y remains the same.)

Before:

Screen Shot 2019-11-25 at 11 20 58 AM

After:

json

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 68.662% when pulling 471391c on toanzian/acc-#1913 into 3826e2f on master.

@tonyanziano tonyanziano merged commit 87af526 into master Nov 25, 2019
@tonyanziano tonyanziano deleted the toanzian/acc-#1913 branch November 25, 2019 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants