Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saga wrapper and webchat bump #2094

Merged
merged 3 commits into from
Mar 7, 2020
Merged

Conversation

srinaath
Copy link
Contributor

@srinaath srinaath commented Mar 7, 2020

This PR handles

  1. Webchat bumped to 4.8
  2. Error handling for all sagas and helps make them stay alive after errors until we move to 1.0+ where the onError hook will be utilized
  3. Multiple clicks on Restart Conversation was not working before. It has been fixed now

Srinaath Ravichandran added 2 commits March 6, 2020 16:55
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

Handling saga errors

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

Revert res.ok

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

Track saga error

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
@coveralls
Copy link

coveralls commented Mar 7, 2020

Coverage Status

Coverage decreased (-0.008%) to 67.749% when pulling fe55270 on srravich/feature/bump-webchat into b844f3d on master.

Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment on lines +145 to +161
function* rootSaga() {
yield all(
applicationSagas.map(saga =>
spawn(function*() {
while (true) {
try {
yield call(saga);
break;
} catch (error) {
console.error('Saga error: ', error); // eslint-disable-line
}
}
})
)
);
}
sagaMiddleware.run(rootSaga);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cwhitten cwhitten merged commit 155eaac into master Mar 7, 2020
@cwhitten cwhitten deleted the srravich/feature/bump-webchat branch March 7, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants