Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle change to middleware #2177

Merged
merged 3 commits into from
Aug 18, 2020
Merged

Conversation

srinaath
Copy link
Contributor

@srinaath srinaath commented Aug 18, 2020

The webchat middleware 4.10.0 returns false for conversationUpdate, invoke events. This PR makes sure it returns true before we render the results

microsoft/BotFramework-WebChat@9e5f9e0#diff-5cc299788131ecb932a8b17abd1ba05bL6

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
tonyanziano
tonyanziano previously approved these changes Aug 18, 2020
@@ -203,6 +207,7 @@ export class Chat extends PureComponent<ChatProps, ChatState> {
return null;

default:
debugger;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to remove this 😅

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@srinaath srinaath merged commit b316c13 into v4.10.0 Aug 18, 2020
@srinaath srinaath deleted the bugfix/handle-middleware-webchat branch August 18, 2020 22:55
tonyanziano pushed a commit that referenced this pull request Aug 31, 2020
* Webchat Upgrade and Version number change

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

* Handle change to middleware (#2177)

* Handle change to middleware

* Updated babel preset env

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

* Reverted change to babel

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

Locks updated to pre webchat change

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

Post wechat check

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

Prevent hoisting bf-chatdown

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

* Updated babel preset env

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

* fix: Webchat socket instantiation delay (#2179)

* Updated websocket server code to backup messages if it is not connected
* Refactored more occurances of socket send
* Renaming variables
* Added unit test to make sure backedup messages are cleared before connection starts
* Lint fix

* Updated release date

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

* All tests working

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>

Co-authored-by: Srinaath Ravichandran <srravich@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants