Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped Electron from 4.1.1 to 11.0.1 #2226

Merged
merged 9 commits into from
Feb 3, 2021
Merged

Conversation

tonyanziano
Copy link
Contributor

@tonyanziano tonyanziano commented Jan 29, 2021

  • Bumped electron to 11.0.1 🚀🚀🚀
  • Bumped typescript to 4.1.3
  • Bumped keytar to 7.3.0
  • Bumped electron-rebuild to 2.3.4
  • Bumped eslint to 7.19.0

Fixed some breaking API changes as a result of bumping Electron

Here's a working Windows CI build: https://fuselabs.visualstudio.com/BotFramework-Emulator/_build/results?buildId=207729&view=artifacts&pathAsName=false&type=publishedArtifacts

The other pipelines will be fixed to accommodate these changes

@coveralls
Copy link

coveralls commented Jan 29, 2021

Coverage Status

Coverage decreased (-0.02%) to 67.767% when pulling 90beb45 on toanzian/electron-bump into c47786f on main.

corinagum
corinagum previously approved these changes Feb 1, 2021
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonyanziano
Copy link
Contributor Author

Thanks for the review @corinagum . I'm going to fix the linting and the tests as well and re-push so I might ping you again for a second review :)

Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one non-blocking question

@tonyanziano tonyanziano merged commit cc523d3 into main Feb 3, 2021
@tonyanziano tonyanziano deleted the toanzian/electron-bump branch February 3, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants