Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed opening files via electron's dialog API #2237

Merged
merged 2 commits into from
Mar 4, 2021

Conversation

tonyanziano
Copy link
Contributor

@tonyanziano tonyanziano commented Mar 3, 2021

After bumping Electron from 4 to 11 we forgot to update our utility function that wraps the dialog.showOpenDialog API to return the correct value. This was causing any type of action that was using a native "Open file" dialog to silently fail -- opening a bot, transcript, etc.

Here is the old documentation that shows the return value of v4.x's showOpenDialog -- it was an array of strings.

The updated API from v11.x returns an object with a filePaths array containing the information that the 4.x version returned.

CI build running here

Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonyanziano tonyanziano merged commit a4685d6 into v4.12.0 Mar 4, 2021
@tonyanziano tonyanziano deleted the toanzian/electron-open-dialog branch March 4, 2021 02:27
tonyanziano added a commit that referenced this pull request Mar 9, 2021
* Added ability to debug shared package (redux state).

* Bumped Web Chat to 4.12.0

* Integrated inspector with new WC activity focus hook

* Updated fallback speech service ponyfill API

* Fixed WC send box overflow visual bug

* Added changelog entry

* v4.12.0 Release

* Fixed opening files via electron's dialog API (#2237)

* Fixed opening files via electron's dialog API

* Added a changelog entry.

* Fixed a bug that was causing Electron's context menu to fail (#2238)

* Updated 4.12.0 release date

* Fixed split button caret icon alignment (#2239)

* Categorized 4.12.0 changes

* Updated path to electron-builder hashFile utility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants