Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed blank inspectors due to new contextIsolation default value #2321

Merged
merged 3 commits into from
Nov 11, 2021

Conversation

tonyanziano
Copy link
Contributor

@tonyanziano tonyanziano commented Nov 11, 2021

…lectron 13

In Electron 13, the default for contextIsolation was set to true when it used to be false.

We tried to change the default for all instances of new browser windows in #2318, but missed the <webview> tag for inspectors. This was causing the inspectors to be cut off from any data passed from the host (Emulator client) resulting in a blank view.

working-inspector

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 67.841% when pulling b561cbb on toanzian/blank-inspector-fix into 0a75699 on main.

@a-b-r-o-w-n a-b-r-o-w-n changed the title Fixed blank inspectors due to new contextIsolation default value in E… Fixed blank inspectors due to new contextIsolation default value Nov 11, 2021
@a-b-r-o-w-n a-b-r-o-w-n merged commit 608f7c2 into main Nov 11, 2021
@a-b-r-o-w-n a-b-r-o-w-n deleted the toanzian/blank-inspector-fix branch November 11, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants