-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement formatter
specializations for container adaptors
#4825
Implement formatter
specializations for container adaptors
#4825
Conversation
@@ -18,6 +18,7 @@ | |||
|
|||
#if _HAS_CXX23 | |||
#include <__msvc_ranges_to.hpp> | |||
#include <format> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently <queue>
and <stack>
are made to include <format>
.
I'll make a follow-up PR to reduce inclusion from <queue>
, <stack>
, <stacktrace>
, and <thread>
.
Using `_AdaptorType::container_type` avoids having to redundantly pass it. `template <class> class _RefView` works around the fact that `_RANGES ref_view` isn't available in `<format>`.
…ter_base::format`.
tests/std/tests/P2286R8_text_formatting_container_adaptors/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2286R8_text_formatting_container_adaptors/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2286R8_text_formatting_container_adaptors/test.cpp
Outdated
Show resolved
Hide resolved
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for completing this major, long-awaited C++23 feature! 😻 🎉 🥳 💚 |
Completes WG21-P2286R8. Implements LWG-3881 and LWG-3750. Fixes #2919.
Unblocks libcxx tests:
std/containers/container.adaptors/container.adaptors.format/format.functions.format.pass.cpp
std/containers/container.adaptors/container.adaptors.format/format.functions.vformat.pass.cpp
std/containers/container.adaptors/container.adaptors.format/parse.pass.cpp
std/containers/container.adaptors/container.adaptors.format/types.compile.pass.cpp
std/utilities/format/format.formattable/concept.formattable.compile.pass.cpp