Implement formatter specializations for container adaptors
#4825
+1,288
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederick-vs-ja
commented
Jul 10, 2024
| @@ -18,6 +18,7 @@ | |||
|
|
|||
| #if _HAS_CXX23 | |||
| #include <__msvc_ranges_to.hpp> | |||
| #include <format> | |||
There was a problem hiding this comment.
Currently <queue> and <stack> are made to include <format>.
I'll make a follow-up PR to reduce inclusion from <queue>, <stack>, <stacktrace>, and <thread>.
Using `_AdaptorType::container_type` avoids having to redundantly pass it. `template <class> class _RefView` works around the fact that `_RANGES ref_view` isn't available in `<format>`.
…ter_base::format`.
tests/std/tests/P2286R8_text_formatting_container_adaptors/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2286R8_text_formatting_container_adaptors/test.cpp
Outdated
Show resolved
Hide resolved
tests/std/tests/P2286R8_text_formatting_container_adaptors/test.cpp
Outdated
Show resolved
Hide resolved
StephanTLavavej
approved these changes
Aug 12, 2024
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for completing this major, long-awaited C++23 feature! 😻 🎉 🥳 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes WG21-P2286R8. Implements LWG-3881 and LWG-3750. Fixes #2919.
Unblocks libcxx tests:
std/containers/container.adaptors/container.adaptors.format/format.functions.format.pass.cppstd/containers/container.adaptors/container.adaptors.format/format.functions.vformat.pass.cppstd/containers/container.adaptors/container.adaptors.format/parse.pass.cppstd/containers/container.adaptors/container.adaptors.format/types.compile.pass.cppstd/utilities/format/format.formattable/concept.formattable.compile.pass.cpp