Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG FIX] The auto generated homebrew tap contains extra double quotation. #151

Merged
merged 2 commits into from
May 22, 2024
Merged

[BUG FIX] The auto generated homebrew tap contains extra double quotation. #151

merged 2 commits into from
May 22, 2024

Conversation

nao1215
Copy link
Owner

@nao1215 nao1215 commented May 22, 2024 •
edited
Loading

Fix this problem.

The template which goreleaser is using passes this as-is, adding surrounding double-quotes. Since the Homebrew formula is just a Ruby DSL, the strings need to be quoted, as such, with your double quotes, you will get a failure per:

Error: nao1215/tap/gup: /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/nao1215/homebrew-tap/gup.rb:6: syntax error, unexpected local variable or method, expecting `end' or dummy end

I was able to reproduce it on my local machine as well.

$ brew install gup
==> Auto-updating Homebrew...
Adjust how often this is run with HOMEBREW_AUTO_UPDATE_SECS or disable with
HOMEBREW_NO_AUTO_UPDATE. Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).

Error: nao1215/tap/gup: /home/linuxbrew/.linuxbrew/Homebrew/Library/Taps/nao1215/homebrew-tap/gup.rb:6: syntax error, unexpected local variable or method, expecting `end' or dummy end
...pdate binaries installed by "go install""

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 22, 2024

Warning

Rate Limit Exceeded

@nao1215 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 8 minutes and 33 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between e0ba5d5 and f1629df.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link
Contributor

Code Metrics Report

main (e0ba5d5) #151 (a241ff9) +/-
Coverage 86.1% 86.1% 0.0%
Test Execution Time 3s 7s +4s
Details 
  |                     | main (e0ba5d5) | #151 (a241ff9) | +/-  |
  |---------------------|----------------|----------------|------|
  | Coverage            |          86.1% |          86.1% | 0.0% |
  |   Files             |             14 |             14 |    0 |
  |   Lines             |            553 |            553 |    0 |
  |   Covered           |            476 |            476 |    0 |
- | Test Execution Time |             3s |             7s |  +4s |

Reported by octocov

@nao1215 nao1215 changed the title Nchika/fix goreleaser [BUG FIX] The auto generated homebrew tap contains extra double quotation. May 22, 2024
@nao1215 nao1215 merged commit 76349dd into main May 22, 2024
19 checks passed
nao1215 referenced this pull request May 22, 2024
@nao1215
Auto generate homebrew tap
c2a6962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nao1215