Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use POSIX compliant calling of head and tail #105

Merged
merged 1 commit into from
May 23, 2020
Merged

use POSIX compliant calling of head and tail #105

merged 1 commit into from
May 23, 2020

Conversation

DerDakon
Copy link
Member

@DerDakon DerDakon commented Oct 5, 2019

No description provided.

@DerDakon DerDakon added this to the 1.09 milestone Dec 27, 2019
schmonz
schmonz reviewed Jan 2, 2020
View reviewed changes
Copy link
Member

@schmonz schmonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any known problems this fixes? Are we pretty sure it doesn't cause any new problems on platforms we're still supporting?

Stakes seems low, but these are my usual questions and I have to ask them :-)

@DerDakon
Copy link
Member Author

DerDakon commented Jan 2, 2020

There are older versions of coreutils that did not support the -1 way, but this has been readded long ago. Gentoo has a special fixup function in ebuilds to change things to the -n version, and the Linux kernel has IIRC fixed also the usage of it to be compliant. So if something is not really old and rotten I guess it will just work as it should.

@leahneukirchen
Copy link
Contributor

LGTM.

josuah
josuah approved these changes May 19, 2020
View reviewed changes
Copy link

@josuah josuah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: only improvement

@DerDakon DerDakon merged commit e90b5a7 into master May 23, 2020
@DerDakon DerDakon deleted the Dakon-headtail branch May 23, 2020 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josuah josuah josuah approved these changes

@mbhangui mbhangui mbhangui approved these changes

@schmonz schmonz schmonz approved these changes

@leahneukirchen leahneukirchen leahneukirchen approved these changes

@alanpost alanpost Awaiting requested review from alanpost

@jlmuir jlmuir Awaiting requested review from jlmuir

@xenotrope xenotrope Awaiting requested review from xenotrope

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.09
Development

Successfully merging this pull request may close these issues.
5 participants
@DerDakon @leahneukirchen @schmonz @mbhangui @josuah