Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qmail-smtpd: allow [] to appear in received lines #170

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Conversation

DerDakon
Copy link
Member

@DerDakon DerDakon commented Jul 7, 2020

A client that can't find out the hostname should send "[ip.ad.dr.ess]" as HELO or EHLO string. But since the square brackets were considered unsafe qmail-smtpd mangled them to ? in the Received line actually written to the mail.

@DerDakon DerDakon added the bug Something isn't working label Jul 7, 2020
@DerDakon DerDakon added this to the 1.09 milestone Jul 7, 2020
@leahneukirchen
Copy link
Contributor

I have a bunch of emails with [] in Received, I don't see how it does harm. 👍

@leahneukirchen
Copy link
Contributor

sqmail also allows spaces, btw.

A client that can't find out the hostname should send "[ip.ad.dr.ess]" as HELO
or EHLO string. But since the square brackets were considered unsafe qmail-smtpd
mangled them to ? in the Received line actually written to the mail.
@DerDakon DerDakon merged commit 8e2f1b0 into master Jul 8, 2020
@DerDakon DerDakon deleted the Dakon-brackets branch July 8, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants