Fix CodeQL cpp/integer-multiplication-cast-to-long. #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerDakon
reviewed
Dec 3, 2020
22ff2ad
to
32fee24
Compare
DerDakon
approved these changes
Dec 3, 2020
mbhangui
approved these changes
Dec 4, 2020
leahneukirchen
approved these changes
Dec 16, 2020
"Multiplication result may overflow 'int' before it is converted to 'long'." Make n a datetime_sec (synonym for long) to begin with.
32fee24
to
2c2b634
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Seen under the project's "code scanning alerts".)
"Multiplication result may overflow 'int' before it is converted to 'long'."
Recommendation: "Use a cast to ensure that the multiplication is done
using the larger integer type to avoid overflow."