Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: update GitHub actions to Ubuntu 22.04 #240

Merged
merged 2 commits into from
Oct 16, 2022
Merged

CI: update GitHub actions to Ubuntu 22.04 #240

merged 2 commits into from
Oct 16, 2022

Conversation

DerDakon
Copy link
Member

This already includes a newer version of check, and the mirror used no longer has hirsute available, so CI builds are currently failing.

While at it bump the version of the checkout action.

This already includes a newer version of check, and the mirror used no longer
has hirsute available, so CI builds are currently failing.
Copy link
Contributor

@mbhangui mbhangui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@schmonz schmonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the hard-to-guess failure, and thanks for looking after it. Next time I do something like this, I’ll try to remember to include an OS version check so we’ll be given a better clue when it’s time to change.

Copy link

@josuah josuah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks harmless to me.

The fact that we stick to one particular Ubuntu version could help to differentiate:

  • a new version of ubuntu breaking something
  • a commit pushed breaking something

@DerDakon
Copy link
Member Author

The reason I use "22.04" instead of "latest" is just that the latter is currently still an alias for "20.04". But I think doing an explicit upgrade here is no bad step, as we can do a check (sic!) before the switch to make sure it actually works.

@DerDakon DerDakon merged commit 2a2533f into master Oct 16, 2022
@DerDakon DerDakon deleted the Dakon-ci branch October 16, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants