clean up interface of substdio functions #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josuah
approved these changes
Mar 25, 2024
schmonz
approved these changes
Apr 5, 2024
These functions are usually called with a character literal as second argument. When these functions are static inlines this allows the compiler to entirely avoid the runtime call to strlen() and pass a constant there. These functions are not turned into defines as that may evaluate the "buf" argument twice which would suddenly emit incorrect code if someone passes things like "buf++".
…flush() This was now the only function without a complete interface in the header.
Provide an interface that matches write(2).
a767d29
to
c260cb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of declaration without arguments in the header, as that causes warnings in most recent compilers. While at it clean up a bit more.
I'm not aware of any patch that modifies substdio.h or any of it's functions, so I think this is safe.