Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove html comments from man entries #4457

Merged
merged 1 commit into from
Feb 22, 2022
Merged

fix: remove html comments from man entries #4457

merged 1 commit into from
Feb 22, 2022

Conversation

wraithgar
Copy link
Member

Before:

   Configuration
       <!-- AUTOGENERATED CONFIG DESCRIPTIONS START --> <!-- automatically generated, do not edit manually -->
       <!-- see lib/utils/config/definitions.js -->

   json

After:

   Configuration
   json

References

@wraithgar wraithgar requested a review from a team as a code owner February 22, 2022 18:00
@wraithgar wraithgar mentioned this pull request Feb 22, 2022
Merged
@npm-robot
Copy link
Contributor

npm-robot commented Feb 22, 2022 •
edited
Loading

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-large clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 54.841 ±5.47 31.166 ±0.24 34.905 ±24.05 20.609 ±0.44 3.051 ±0.13 3.049 ±0.08 2.580 ±0.06 11.559 ±0.02 2.417 ±0.01 3.437 ±0.04
#4457 0.433 ±0.01 0.428 ±0.00 0.425 ±0.00 0.449 ±0.01 0.440 ±0.00 0.431 ±0.00 0.426 ±0.00 0.425 ±0.02 0.428 ±0.00 0.426 ±0.01
app-medium clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 37.735 ±1.82 23.452 ±0.09 13.131 ±0.04 14.145 ±0.07 2.813 ±0.01 2.756 ±0.05 2.392 ±0.04 8.733 ±0.03 2.234 ±0.00 3.182 ±0.01
#4457 0.439 ±0.02 0.428 ±0.00 0.420 ±0.01 0.433 ±0.02 0.451 ±0.04 0.455 ±0.01 0.450 ±0.00 0.422 ±0.00 0.426 ±0.01 0.424 ±0.02

@lukekarrys lukekarrys merged commit c9ff797 into release-next Feb 22, 2022
@lukekarrys lukekarrys deleted the gar/man-comments branch February 22, 2022 19:48
@lukekarrys lukekarrys mentioned this pull request Feb 24, 2022
Merged
@npm-robot npm-robot mentioned this pull request Feb 24, 2022
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukekarrys lukekarrys lukekarrys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wraithgar @npm-robot @lukekarrys