Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: explain that git-tag-version=false does not commit #4574

Merged
merged 1 commit into from
Mar 17, 2022
Merged

docs: explain that git-tag-version=false does not commit #4574

merged 1 commit into from
Mar 17, 2022

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Mar 16, 2022 •
edited
Loading

Closes #3710

@wraithgar wraithgar requested a review from a team as a code owner March 16, 2022 17:58
@nlf nlf merged commit ddbb505 into latest Mar 17, 2022
@nlf nlf deleted the gar/git-tag-docs branch March 17, 2022 18:23
@npm-robot
Copy link
Contributor

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 45.338 ±0.95 27.278 ±0.14 15.738 ±0.19 17.542 ±0.80 2.580 ±0.01 2.631 ±0.12 2.115 ±0.03 9.902 ±0.13 2.073 ±0.08 2.993 ±0.07
#4574 44.497 ±0.50 25.552 ±0.09 15.161 ±0.42 17.849 ±1.43 2.610 ±0.13 2.524 ±0.00 2.043 ±0.03 9.813 ±0.02 1.986 ±0.01 3.357 ±0.52
app-medium clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 32.613 ±0.82 19.951 ±0.08 11.186 ±0.24 12.374 ±0.15 2.262 ±0.05 2.279 ±0.00 2.005 ±0.04 7.134 ±0.06 1.860 ±0.01 2.671 ±0.00
#4574 33.283 ±0.62 20.522 ±0.02 11.062 ±0.05 12.146 ±0.46 2.292 ±0.02 2.229 ±0.01 2.027 ±0.01 7.489 ±0.08 1.886 ±0.00 2.718 ±0.05

@nlf nlf mentioned this pull request Mar 17, 2022
Merged
@npm-robot npm-robot mentioned this pull request Mar 17, 2022
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlf nlf nlf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS] git-tag-version=false does not commit
3 participants
@wraithgar @npm-robot @nlf