Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(libnpmpublish): unpublish from custom reg #4657

Merged
merged 1 commit into from
Apr 26, 2022
Merged

fix(libnpmpublish): unpublish from custom reg #4657

merged 1 commit into from
Apr 26, 2022

Conversation

ruyadorno
Copy link
Contributor

Fixes unpublishing a package from a registry url that has pathnames after its hostname.

References

Fixes: #4253

@ruyadorno ruyadorno requested a review from a team as a code owner March 31, 2022 22:47
@ruyadorno ruyadorno added semver:patch semver patch level for changes Release 8.x work is associated with a specific npm 8 release release: next These items should be addressed in the next release labels Mar 31, 2022
@ruyadorno ruyadorno mentioned this pull request Mar 31, 2022
Closed
@ruyadorno ruyadorno force-pushed the test-libnpmpublish-unpublish-custom-registry branch from 834e2ef to 31f4b71 Compare April 19, 2022 18:57
@ruyadorno
fix(libnpmpublish): unpublish from custom reg
6fc2c38 
Fixes unpublishing a package from a registry url that has pathnames
after its hostname.

Fixes: npm#4253
@ruyadorno ruyadorno force-pushed the test-libnpmpublish-unpublish-custom-registry branch from 31f4b71 to 6fc2c38 Compare April 19, 2022 19:15
nlf
nlf approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix!

@ruyadorno ruyadorno merged commit e9163b4 into npm:latest Apr 26, 2022
@github-actions github-actions bot mentioned this pull request Apr 26, 2022
Merged
@ruyadorno ruyadorno mentioned this pull request Apr 26, 2022
Merged
@npm-robot npm-robot mentioned this pull request Apr 27, 2022
Merged
This was referenced Aug 22, 2022
Closed
Closed
Closed
@github-actions github-actions bot mentioned this pull request Aug 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar left review comments

@ljharb ljharb ljharb left review comments

@nlf nlf nlf approved these changes

Assignees
No one assigned
Labels
release: next These items should be addressed in the next release Release 8.x work is associated with a specific npm 8 release semver:patch semver patch level for changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG](libnpmpublish) Unpublish url not correctly defined
4 participants
@ruyadorno @wraithgar @ljharb @nlf