Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mitigate doctor test race condition #4741

Merged
merged 1 commit into from
Apr 13, 2022
Merged

fix: mitigate doctor test race condition #4741

merged 1 commit into from
Apr 13, 2022

Conversation

wraithgar
Copy link
Member

cacache appears to not write everything to the cache by the time doctor
is checking permissions. This limits the permissions error to a single
directory that we know exists by the time the checks run.

@wraithgar
fix: mitigate doctor test race condition
a53c35e 
cacache appears to not write everything to the cache by the time doctor
is checking permissions.  This limits the permissions error to a single
directory that we know exists by the time the checks run.
@wraithgar wraithgar requested a review from a team as a code owner April 13, 2022 15:44
@npm-robot
Copy link
Contributor

found 1 benchmarks with statistically significant performance improvements

  • app-large: no-cache
timing results
app-large clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 48.123 ±0.10 29.582 ±0.39 16.816 ±0.09 19.215 ±0.66 2.856 ±0.01 2.883 ±0.01 2.376 ±0.13 10.824 ±0.09 2.281 ±0.00 3.293 ±0.01
#4741 52.498 ±8.24 29.105 ±0.09 27.452 ±15.06 18.707 ±1.14 2.681 ±0.11 2.614 ±0.03 2.086 ±0.04 10.364 ±0.01 2.203 ±0.00 3.231 ±0.22
app-medium clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 36.185 ±1.07 22.593 ±0.20 12.399 ±0.07 13.543 ±0.51 2.631 ±0.01 2.669 ±0.01 2.351 ±0.03 8.106 ±0.04 2.160 ±0.00 2.974 ±0.01
#4741 38.811 ±0.82 22.315 ±0.55 11.873 ±0.10 12.733 ±0.03 2.462 ±0.05 2.438 ±0.02 2.139 ±0.02 7.851 ±0.14 2.037 ±0.03 2.822 ±0.12

@fritzy fritzy merged commit 0cd852f into latest Apr 13, 2022
@fritzy fritzy deleted the gar/doctor-test-race-condition branch April 13, 2022 21:36
@lukekarrys lukekarrys mentioned this pull request Apr 14, 2022
Merged
@npm-robot npm-robot mentioned this pull request Apr 14, 2022
Closed
@Omrisnyk Omrisnyk mentioned this pull request Sep 5, 2024
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukekarrys lukekarrys lukekarrys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wraithgar @npm-robot @lukekarrys @fritzy