-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(view): dont immediately exit on first workspace 404 #7508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no statistically significant performance changes detected timing results
|
lukekarrys
force-pushed
the
lk/view-json-errors-workspace
branch
4 times, most recently
from
May 11, 2024 04:46
b3de0de
to
160d6e9
Compare
lukekarrys
force-pushed
the
lk/view-json-errors-workspace
branch
19 times, most recently
from
May 13, 2024 02:57
3b959de
to
b4b4f22
Compare
lukekarrys
force-pushed
the
lk/errors-and-json
branch
from
May 13, 2024 03:01
1bdb860
to
db68fd2
Compare
lukekarrys
force-pushed
the
lk/view-json-errors-workspace
branch
from
May 13, 2024 04:26
b4b4f22
to
1bc9bb4
Compare
lukekarrys
force-pushed
the
lk/errors-and-json
branch
from
May 13, 2024 05:29
350d3c1
to
9e3cae2
Compare
lukekarrys
force-pushed
the
lk/view-json-errors-workspace
branch
from
May 13, 2024 07:01
1bc9bb4
to
76fd359
Compare
lukekarrys
force-pushed
the
lk/view-json-errors-workspace
branch
2 times, most recently
from
May 14, 2024 18:07
1ede923
to
a419471
Compare
lukekarrys
force-pushed
the
lk/publish-output-buffer
branch
from
May 15, 2024 19:11
9da2d27
to
11a49f9
Compare
lukekarrys
force-pushed
the
lk/view-json-errors-workspace
branch
from
May 15, 2024 22:02
a419471
to
39f157f
Compare
lukekarrys
changed the title
fix(view): output full json object with errors with workspaces
fix(view): dont exit on workspace 404
May 15, 2024
lukekarrys
changed the title
fix(view): dont exit on workspace 404
fix(view): dont immediately exit on first workspace 404
May 15, 2024
wraithgar
approved these changes
May 16, 2024
This also removes the last two |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5444
This PR will continue running through all workspaces for
npm view
even when a workspace encounters anE404
error. This usually happens when you runnpm view -ws
but have private workspaces. A future iteration could log a different message if anE404
is encountered on a private workspace, but for this PR I wanted to keep it generic since there are a number of reasons a request for a package manifest could 404.npm view . version -ws
npm view . version -ws --json