Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cache): add both full and minified packument to cache #7516

Merged
merged 1 commit into from
May 22, 2024

Conversation

milaninfy
Copy link
Contributor

@milaninfy milaninfy commented May 13, 2024

This will fix the npm cache add to cache package with same header as it's used in npm install by adding extra manifest call with fullMetadata: true while caching to match behaviour with install command which internally request manifest with fullMetadata.

References

Closes #7465

@milaninfy milaninfy marked this pull request as ready for review May 22, 2024 13:37
@milaninfy milaninfy requested a review from a team as a code owner May 22, 2024 13:37
@wraithgar wraithgar changed the title fix(cache): cache add fix(cache): add both full and minified packument to cache May 22, 2024
@wraithgar wraithgar merged commit 9122fb6 into npm:latest May 22, 2024
25 checks passed
@github-actions github-actions bot mentioned this pull request May 20, 2024
@milaninfy milaninfy deleted the mm/fix-cache-add branch May 29, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] install and cache add disagrees on accept header
2 participants